From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Shevchenko <andy@smile.org.ua>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [SDIO] add vendor and product pair for SQN1130
Date: Fri, 7 Mar 2008 12:40:58 +0100 [thread overview]
Message-ID: <20080307124058.052a62ba@mjolnir.drzeus.cx> (raw)
In-Reply-To: <20080307024526.17ff6401.akpm@linux-foundation.org>
On Fri, 7 Mar 2008 02:45:26 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:
> On Fri, 7 Mar 2008 10:08:30 +0200 Andy Shevchenko <andy@smile.org.ua> wrote:
>
> > Add the vendor and product ids for Sequans SQN1130 WiMAX chipset.
> > ---
> > include/linux/mmc/sdio_ids.h | 3 +++
> > 1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
> > index ea1bf5b..d1b9883 100644
> > --- a/include/linux/mmc/sdio_ids.h
> > +++ b/include/linux/mmc/sdio_ids.h
> > @@ -26,4 +26,7 @@
> > #define SDIO_VENDOR_ID_MARVELL 0x02df
> > #define SDIO_DEVICE_ID_MARVELL_LIBERTAS 0x9103
> >
> > +#define SDIO_VENDOR_ID_SEQUANS 0x039d
> > +#define SDIO_DEVICE_ID_SEQUANS_SQN1130 0x046a
> > +
>
> There's no point in adding these unless there's actually some code there
> which _uses_ them?
Agreed. This is just noise.
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
prev parent reply other threads:[~2008-03-07 11:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-07 8:08 [PATCH] [SDIO] add vendor and product pair for SQN1130 Andy Shevchenko
2008-03-07 10:45 ` Andrew Morton
2008-03-07 11:40 ` Pierre Ossman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080307124058.052a62ba@mjolnir.drzeus.cx \
--to=drzeus-list@drzeus.cx \
--cc=akpm@linux-foundation.org \
--cc=andy@smile.org.ua \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox