From: Matthew Wilcox <matthew@wil.cx>
To: Pavel Emelyanov <xemul@openvz.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Luck, Tony" <tony.luck@intel.com>,
linux-ia64@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ia64: fix getpid and set_tid_address fast system calls for pid namespaces
Date: Fri, 7 Mar 2008 06:51:20 -0700 [thread overview]
Message-ID: <20080307135120.GA29388@parisc-linux.org> (raw)
In-Reply-To: <47D141C1.2030604@openvz.org>
On Fri, Mar 07, 2008 at 04:23:13PM +0300, Pavel Emelyanov wrote:
> @@ -34,6 +35,9 @@
> DEFINE(SIGFRAME_SIZE, sizeof (struct sigframe));
> DEFINE(UNW_FRAME_INFO_SIZE, sizeof (struct unw_frame_info));
>
> + BUILD_BUG_ON(sizeof(struct upid) != 32);
> + DEFINE(IA64_UPID_SHIFT, 5);
> +
> BLANK();
>
> DEFINE(TI_FLAGS, offsetof(struct thread_info, flags));
This might work better with ilog2(). Something like this perhaps?
BUILD_BUG_ON(!is_power_of_2(sizeof(struct upid)))
DEFINE(IA64_UPID_SHIFT, ilog2(sizeof(struct upid)))
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
prev parent reply other threads:[~2008-03-07 13:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-07 13:23 [PATCH] ia64: fix getpid and set_tid_address fast system calls for pid namespaces Pavel Emelyanov
2008-03-07 13:51 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080307135120.GA29388@parisc-linux.org \
--to=matthew@wil.cx \
--cc=akpm@linux-foundation.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox