From: David Brownell <david-b@pacbell.net>
To: linux-arm-kernel@lists.arm.linux.org.uk
Cc: Liam Girdwood <lg@opensource.wolfsonmicro.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [UPDATED v3][PATCH 5/7] regulator: sysfs ABI
Date: Fri, 7 Mar 2008 17:13:57 -0800 [thread overview]
Message-ID: <200803071713.57795.david-b@pacbell.net> (raw)
In-Reply-To: <1204827125.15360.151.camel@a10323.wolfsonmicro.main>
On Thursday 06 March 2008, Liam Girdwood wrote:
> +What: /sys/class/regulator/.../microvolts
> + ...
> +
> +What: /sys/class/regulator/.../microamps
> + ...
Versus Documentation/hwmon/sysfs-interface which uses
millivolts and milliamperes respectively.
Why not adopt the same convention? (This applies to
many attributes, not just these two.)
Also, I'm kind of curious what you've thought about
power budgeting. Example, a power supply ("regulator")
may be able to supply a voltage within a given range,
but only up to a maximum of 200 mA worth.
The model visible through these sysfs attributes seems to
be an either/or thing ... either regulating voltage, or
current, but not addressing the corresponding constraints
on the other one.
> + NOTE: this will return the string 'constraint not defined'
How about just "undefined" for all those min/max values?
> +What: /sys/class/regulator/.../requested_microamps
> + ...
Ditto re "milli" vs "micro". Also, "requested" seems a bit opaque.
As a sum, maybe "total_mi{lli,cro}amps" would be more explanatory.
- Dave
next prev parent reply other threads:[~2008-03-08 1:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 18:12 [UPDATED v3][PATCH 5/7] regulator: sysfs ABI Liam Girdwood
2008-03-07 16:12 ` Greg KH
2008-03-07 21:17 ` Mark Brown
2008-03-08 1:17 ` David Brownell
2008-03-08 5:52 ` Greg KH
2008-03-08 17:26 ` Liam Girdwood
2008-03-08 1:13 ` David Brownell [this message]
2008-03-08 21:13 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803071713.57795.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=lg@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox