From: Gautham R Shenoy <ego@in.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
Dhaval Giani <dhaval@linux.vnet.ibm.com>
Subject: Re: [PATCH] x86: Don't send RESCHEDULE_VECTOR to offlined cpus
Date: Mon, 10 Mar 2008 18:24:14 +0530 [thread overview]
Message-ID: <20080310125414.GE17646@in.ibm.com> (raw)
In-Reply-To: <20080310122418.GA12101@elte.hu>
On Mon, Mar 10, 2008 at 01:24:18PM +0100, Ingo Molnar wrote:
>
> * Gautham R Shenoy <ego@in.ibm.com> wrote:
>
> > x86: Don't send RESCHEDULE_VECTOR to offlined cpus.
> > From: Gautham R Shenoy <ego@in.ibm.com>
> >
> > In the x86 native_smp_send_reschedule_function(), don't send the IPI
> > if the cpu has gone offline already. Warn nevertheless!!
>
> have you seen this happen?
Yup, this afternoon while running
cpu-hotplug stress tests (http://lkml.org/lkml/2008/3/3/11)
in parallel with kern-bench, I got this on the serial console.
------------[ cut here ]------------
WARNING: at arch/x86/kernel/smp_32.c:475 native_smp_send_reschedule+0x22/0x3f()
Modules linked in: dock
Pid: 4722, comm: kstopmachine Not tainted 2.6.25-rc3 #46
[<c011f424>] warn_on_slowpath+0x41/0x51
[<c013ac74>] ? __lock_acquire+0xaae/0xaf6
[<c011a446>] ? resched_cpu+0x2c/0x6f
[<c0111691>] native_smp_send_reschedule+0x22/0x3f
[<c01186c7>] __resched_task+0x5f/0x63
[<c011a479>] resched_cpu+0x5f/0x6f
[<c011bb6d>] scheduler_tick+0x214/0x28f
[<c012737b>] update_process_times+0x3d/0x49
[<c013751d>] tick_sched_timer+0x6e/0xa6
[<c01374af>] ? tick_sched_timer+0x0/0xa6
[<c0131e8c>] __run_hrtimer+0x39/0x70
[<c0132668>] hrtimer_interrupt+0xeb/0x154
[<c01127bc>] smp_apic_timer_interrupt+0x6c/0x80
[<c0143670>] ? stopmachine+0x0/0x98
[<c0105553>] apic_timer_interrupt+0x33/0x38
[<c0143670>] ? stopmachine+0x0/0x98
[<c013007b>] ? sample_to_timespec+0x16/0x35
[<c0143701>] ? stopmachine+0x91/0x98
[<c01056eb>] kernel_thread_helper+0x7/0x10
=======================
---[ end trace 1016b68a0b60b50b ]---
------------[ cut here ]------------
>
> Ingo
--
Thanks and Regards
gautham
next prev parent reply other threads:[~2008-03-10 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-10 12:14 [PATCH] x86: Don't send RESCHEDULE_VECTOR to offlined cpus Gautham R Shenoy
2008-03-10 12:24 ` Ingo Molnar
2008-03-10 12:54 ` Gautham R Shenoy [this message]
2008-03-10 15:32 ` Roel Kluin
2008-03-10 16:36 ` Gregory Haskins
2008-03-11 9:21 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080310125414.GE17646@in.ibm.com \
--to=ego@in.ibm.com \
--cc=dhaval@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox