From: Andrew Morton <akpm@linux-foundation.org>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
tony.luck@intel.com, tomof@acm.org
Subject: Re: [PATCH -mm] ia64: make IOMMU respect the segment boundary limits
Date: Mon, 10 Mar 2008 20:33:44 -0700 [thread overview]
Message-ID: <20080310203344.acf50d71.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080310221538U.tomof@acm.org>
On Mon, 10 Mar 2008 22:17:20 +0900 FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote:
> This patch is another sequel to my patchset that fixes iommu segment
> boundary problems, that is, IOMMUs allocate memory areas without
> considering a low level driver's segment boundary limits:
>
> http://www.mail-archive.com/linux-scsi@vger.kernel.org/msg11919.html
Please make this easier.
afacit the patches to which you refer are already in mainline, so this is
*not* a "-mm" patch. It is needed in mainline, correct?
> This patchset fixes the IA64 IOMMU code.
And if it fixes a bug then it is needed in 2.6.25.
Is that correct?
> This assumes that ioc->ibase is on iovp_size boundary. If not, please
> let me know. I'll fix the patch.
Who is the person who who knows the answer to this?
Does this mean that the patch wasn't runtime tested? If so, how do you
know there is a bug?
> =
> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Subject: [PATCH -mm] ia64: make IOMMU respect the segment boundary limits
>
> This makes IA64's IOMMU implementation not allocate a memory area
> spanning LLD's segment boundary.
This changelog doesn't actually tell us that this patch fixed a bug.
It should tell us what the bug is, and how it fixed it, please.
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---
> arch/ia64/Kconfig | 3 ++
> arch/ia64/hp/common/sba_iommu.c | 56 +++++++++++++++++++++++++++------------
next prev parent reply other threads:[~2008-03-11 3:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-10 13:17 [PATCH -mm] ia64: make IOMMU respect the segment boundary limits FUJITA Tomonori
2008-03-11 3:33 ` Andrew Morton [this message]
2008-03-11 4:42 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080310203344.acf50d71.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomof@acm.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox