From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Andi Kleen <andi@firstfloor.org>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty_ioctl: locking for tty_wait_until_sent
Date: Mon, 10 Mar 2008 22:06:43 +0000 [thread overview]
Message-ID: <20080310220643.60f36bee@core> (raw)
In-Reply-To: <87od9m5iu4.fsf@basil.nowhere.org>
On 10 Mar 2008 23:12:51 +0100
Andi Kleen <andi@firstfloor.org> wrote:
> Alan Cox <alan@lxorguk.ukuu.org.uk> writes:
>
> > This function still depends on the big kernel lock in some cases. Push
> > locking into the function ready for removal of the BKL from ioctl call
> > paths.
>
> Didn't you forget the .ioctl -> .unlocked_ioctl change?
We are not yet ready to unlock the device ioctl paths for tty. We still
explicitly take the BKL in the ioctl paths when calling the following
methods
driver:
->wait_until_sent()
->break_ctl()
->tiocmget
->tiocmset
->ioctl
ldisc:
->ioctl
As well as all the open/close/hangup/ldisc change logic
I'm pretty close to removing it from the modem , ioctl and break methods
and its working for me but needs a few drivers tweaking further.
next prev parent reply other threads:[~2008-03-10 22:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-10 21:53 [PATCH] tty_ioctl: locking for tty_wait_until_sent Alan Cox
2008-03-10 22:12 ` Andi Kleen
2008-03-10 22:06 ` Alan Cox [this message]
2008-03-10 22:28 ` Andi Kleen
2008-03-10 23:16 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080310220643.60f36bee@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox