From: Andi Kleen <andi@firstfloor.org>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: pageexec@freemail.hu, Ingo Molnar <mingo@elte.hu>,
Srinivasa DS <srinivasa@in.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, ananth@in.ibm.com,
Jim Keniston <jkenisto@us.ibm.com>,
srikar@linux.vnet.ibm.com,
SystemTAP <systemtap@sources.redhat.com>,
Andi Kleen <andi@firstfloor.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH] x86 - Enhance DEBUG_RODATA support - alternatives
Date: Tue, 11 Mar 2008 13:17:14 +0100 [thread overview]
Message-ID: <20080311121714.GG18917@one.firstfloor.org> (raw)
In-Reply-To: <20080306172509.GA14284@Krystal>
> First, that calling this text_poke implementation to modify text in a
> module won't fail. Is virt_to_page(addr) ok if addr is in a vmalloc'ed
> area ?
virt_to_page only works on direct mapping addresses, not vmalloc.
>
> Second, that calling virt_to_page(addr + PAGE_SIZE) won't have
> undesirable side-effects if addr happens to be in the last page of an
> allocated range. It should be ok for the core kernel text, because it is
> followed by the kernel rodata, but I am not certain for modules.
On non vmemmap/none flatmem kernels it could fail yes. But vmalloc/module_alloc
is not guaranteed to be continuous so you cannot do that anyways.
-Andi
next prev parent reply other threads:[~2008-03-11 12:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 12:41 [BUG] Kprobes fails on 2.6.25-rc3-mm1 (x86) systems, if CONFIG_DEBUG_RODATA is set Srinivasa DS
2008-03-06 12:55 ` Mathieu Desnoyers
2008-03-06 13:33 ` Srinivasa DS
2008-03-06 13:48 ` [PATCH] x86 - Enhance DEBUG_RODATA support - alternatives Mathieu Desnoyers
2008-03-06 14:01 ` Ingo Molnar
2008-03-06 13:59 ` pageexec
2008-03-06 15:52 ` Ingo Molnar
2008-03-06 16:21 ` Andi Kleen
2008-03-06 17:25 ` Mathieu Desnoyers
2008-03-11 12:17 ` Andi Kleen [this message]
2008-03-06 14:18 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080311121714.GG18917@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=arjan@infradead.org \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=pageexec@freemail.hu \
--cc=srikar@linux.vnet.ibm.com \
--cc=srinivasa@in.ibm.com \
--cc=systemtap@sources.redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox