From: Ingo Molnar <mingo@elte.hu>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.25-rc5] x86: correct/clarify comment in nops.h
Date: Tue, 11 Mar 2008 17:19:05 +0100 [thread overview]
Message-ID: <20080311161901.GA32355@elte.hu> (raw)
In-Reply-To: <18390.43171.335608.379379@harpo.it.uu.se>
* Mikael Pettersson <mikpe@it.uu.se> wrote:
> <asm-x86/nops.h> describes certain multibyte instructions as "generic"
> nops when in fact they aren't nops at all in 64-bit mode (missing
> REX.W causing truncation of a register).
>
> Update the comment to state that K8 or P6 style nops should be used in
> 64-bit mode. This matches what the alternatives code does.
> /* generic versions from gas
> 1: nop
> + the following instructions are NOT nops in 64-bit mode,
> + for 64-bit mode use K8 or P6 nops instead
> 2: movl %esi,%esi
> 3: leal 0x00(%esi),%esi
> 4: leal 0x00(,%esi,1),%esi
thanks Mikael, applied.
Ingo
prev parent reply other threads:[~2008-03-11 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-11 15:43 [PATCH 2.6.25-rc5] x86: correct/clarify comment in nops.h Mikael Pettersson
2008-03-11 16:19 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080311161901.GA32355@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox