From: Oleg Nesterov <oleg@tv-sign.ru>
To: Roland McGrath <roland@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Pavel Emelyanov <xemul@openvz.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] signals: unify send_sigqueue/send_group_sigqueue completely
Date: Tue, 11 Mar 2008 21:11:27 +0300 [thread overview]
Message-ID: <20080311181127.GC586@tv-sign.ru> (raw)
In-Reply-To: <20080311020759.B550126F991@magilla.localdomain>
On 03/10, Roland McGrath wrote:
>
> Looks fine. But I'd like a comment on the "ret = 1" case making
> explicit what that magic return case is for and why the value
> matters (to posix_timer_event).
Well, currently this helper is solely used by posix_timer_event(), but despite
the fact it has BUG_ON(!SI_TIMER) it is quite generic, there were patches which
used it for aio.
So I don't think we should document the interaction with posix timers, but OK,
I'll send a small comment update.
Oleg.
next prev parent reply other threads:[~2008-03-11 18:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-08 15:10 [PATCH 5/6] signals: unify send_sigqueue/send_group_sigqueue completely Oleg Nesterov
2008-03-11 2:07 ` Roland McGrath
2008-03-11 18:11 ` Oleg Nesterov [this message]
2008-03-11 20:29 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080311181127.GC586@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox