* [PATCH -mm] x86 halt warning fix
@ 2008-03-12 10:08 Dave Young
2008-03-12 10:44 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Dave Young @ 2008-03-12 10:08 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel
While halting kernel report warning at arch/x86/kernel/reboot.c : 424
fix the WARN_ON_ONCE param to ret
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
arch/x86/kernel/reboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -upr linux/arch/x86/kernel/reboot.c linux.new/arch/x86/kernel/reboot.c
--- linux/arch/x86/kernel/reboot.c 2008-03-12 17:56:48.000000000 +0800
+++ linux.new/arch/x86/kernel/reboot.c 2008-03-12 17:58:43.000000000 +0800
@@ -421,7 +421,7 @@ static void native_machine_shutdown(void
schedparm.sched_priority = 99;
ret = sched_setscheduler(current, SCHED_RR, &schedparm);
- WARN_ON_ONCE(1);
+ WARN_ON_ONCE(ret);
set_cpus_allowed(current, cpumask_of_cpu(reboot_cpu_id));
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -mm] x86 halt warning fix
2008-03-12 10:08 [PATCH -mm] x86 halt warning fix Dave Young
@ 2008-03-12 10:44 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-03-12 10:44 UTC (permalink / raw)
To: Dave Young; +Cc: akpm, linux-kernel
* Dave Young <hidave.darkstar@gmail.com> wrote:
> While halting kernel report warning at arch/x86/kernel/reboot.c : 424
> fix the WARN_ON_ONCE param to ret
thanks, applied.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-12 10:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-12 10:08 [PATCH -mm] x86 halt warning fix Dave Young
2008-03-12 10:44 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox