From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: David Brownell <david-b@pacbell.net>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] gpiolib: add __must_check attribute to the gpiochip_add function
Date: Wed, 12 Mar 2008 15:39:13 +0300 [thread overview]
Message-ID: <20080312123913.GA13266@localhost.localdomain> (raw)
In-Reply-To: <200803111402.38671.david-b@pacbell.net>
On Tue, Mar 11, 2008 at 01:02:38PM -0800, David Brownell wrote:
> On Tuesday 11 March 2008, Anton Vorontsov wrote:
> >
> > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>
> I'm curious why you want to change this. When it fails, a
> KERN_ERR message is emitted ...
Ah, I missed that the gpiochip_add() issuing pr_err(), not pr_debug().
So, please just ignore that patch. Though, printing errors from the
generic functions is confusing, you never know when your code or the
function you call should print the error. And usually generic functions
tend to be silent...
--
Anton Vorontsov
email: cboumailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2008-03-12 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-11 17:41 [PATCH 3/3] gpiolib: add __must_check attribute to the gpiochip_add function Anton Vorontsov
2008-03-11 21:02 ` David Brownell
2008-03-12 12:39 ` Anton Vorontsov [this message]
2008-03-12 23:07 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080312123913.GA13266@localhost.localdomain \
--to=avorontsov@ru.mvista.com \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox