From: David Brownell <david-b@pacbell.net>
To: avorontsov@ru.mvista.com
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] gpiolib: add __must_check attribute to the gpiochip_add function
Date: Wed, 12 Mar 2008 15:07:53 -0800 [thread overview]
Message-ID: <200803121607.54348.david-b@pacbell.net> (raw)
In-Reply-To: <20080312123913.GA13266@localhost.localdomain>
On Wednesday 12 March 2008, Anton Vorontsov wrote:
> On Tue, Mar 11, 2008 at 01:02:38PM -0800, David Brownell wrote:
> > On Tuesday 11 March 2008, Anton Vorontsov wrote:
> > >
> > > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> >
> > I'm curious why you want to change this. When it fails, a
> > KERN_ERR message is emitted ...
>
> Ah, I missed that the gpiochip_add() issuing pr_err(), not pr_debug().
>
> So, please just ignore that patch.
OK ...
> Though, printing errors from the
> generic functions is confusing, you never know when your code or the
> function you call should print the error. And usually generic functions
> tend to be silent...
The logic in this case was that I don't really expect platform
setup code to check this stuff any more than it checks IRQ setup.
But, as the comment says, if platform setup code goofs, it can
cause un-bootable systems. Ergo the pr_err().
It could be argued either way; that's just what I did, way back
when I noticed the issue.
- Dave
prev parent reply other threads:[~2008-03-12 23:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-11 17:41 [PATCH 3/3] gpiolib: add __must_check attribute to the gpiochip_add function Anton Vorontsov
2008-03-11 21:02 ` David Brownell
2008-03-12 12:39 ` Anton Vorontsov
2008-03-12 23:07 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803121607.54348.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=avorontsov@ru.mvista.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox