From: Al Viro <viro@ZenIV.linux.org.uk>
To: David Woodhouse <dwmw2@infradead.org>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
matthew@wil.cx, dhowells@redhat.com
Subject: Re: [PATCH] Remove <linux/genhd.h> from user-visible headers.
Date: Wed, 12 Mar 2008 17:18:33 +0000 [thread overview]
Message-ID: <20080312171833.GI27894@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1205340777.2592.134.camel@shinybook.infradead.org>
On Wed, Mar 12, 2008 at 05:52:56PM +0100, David Woodhouse wrote:
> It was all wrapped in '#ifdef CONFIG_BLOCK' anyway, so userspace was
> getting nothing useful out of it. And the special #ifndef __KERNEL__
> version of 'struct partition' makes me inclined to promote an attitude
> of violence...
>
> Stick some comments on some of the #endifs too, while we're at it.
Right... Actually, if that goes in... the next step is to take fs/partitions
to block and evict more than a half of genhd.h to block/blk.h and relevant
partition handlers. I have a long-rotten patch for that, will resurrect...
prev parent reply other threads:[~2008-03-12 17:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 16:52 [PATCH] Remove <linux/genhd.h> from user-visible headers David Woodhouse
2008-03-12 17:18 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080312171833.GI27894@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox