Re: pcibios_scanned needs to be set in ACPI? (was Re: 2.6.25-rc5: Reported regressions from 2.6.24)

Yinghai Lu
2008-03-13T06:25:13Z

On Wed, Mar 12, 2008 at 10:44 PM, Greg KH <greg@kroah.com> wrote:
> On Wed, Mar 12, 2008 at 04:09:17PM -0700, Linus Torvalds wrote:
> >
> >
>
> > On Wed, 12 Mar 2008, Greg KH wrote:
> > >
> > > I can't get a box here to produce both of those PCI: messages myself,
> > > and neither can Len, so something is really odd here.
>
> Ok, stupid me, this was my fault. I was assuming that pci busses would
> never be registered multiple times with the pci core. Obviously this
> isn't true. The previous patch I proposed was only paying attention to
> the PCI devices, and that logic is just fine (it's already protected
> when it is attempted to be registered multiple times.)
>
> So, the patch below fixes the issue for me, and reboot seems to work as
> well.
>
> Guennadi, can you test this out on your machine?
>
> thanks for your patience,
>
> greg k-h
>
>
> From: Greg Kroah-Hartman <gregkh@suse.de>
> Subject: PCI: fix issue with busses registering multiple times in sysfs
>
> PCI busses can be registered multiple times, so we need to detect if we
> have registered our bus structure in sysfs already. If so, don't do it
> again.
>
> Thanks to Guennadi Liakhovetski <g.liakhovetski@gmx.de> for reporting
> the problem, and to Linus for poking me to get me to believe that it was
> a real problem.
>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

wonder if

http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=commitdiff;h=fff07473e243989a2739b9d802d63e051ade7188

helps.

YH