Re: pm_register() and pm_send_all()

Pavel Machek
2008-03-13T18:06:26Z

On Thu 2008-03-13 14:19:17, Ralf Baechle wrote:
> On Thu, Mar 13, 2008 at 12:28:23PM +0000, Ralf Baechle wrote:
>
> > Looks correct to me, thus ACK.
> >
> > Spinning that a little further I wonder how useful the rest of the
> > Alchemy code - which seems to only deal with devices - is. If at all.
> > I'm going to check with some Alchemy users if that code actually works or
> > can be removed. I think the latter. Also there is the APM emulation
> > available which provides similar functionality.
>
> So here a patch do cleanup a part. Probably more to come
>
> From: Ralf Baechle <ralf@linux-mips.org>
>
> [MIPS] Alchey: Crapectomy after removal of pm_send_all calls.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

ACK.

>
> arch/mips/au1000/common/power.c | 20 --------------------
> 1 file changed, 20 deletions(-)
>
> Index: linux-mips/arch/mips/au1000/common/power.c
> ===================================================================
> --- linux-mips.orig/arch/mips/au1000/common/power.c
> +++ linux-mips/arch/mips/au1000/common/power.c
> @@ -283,18 +283,6 @@ static int pm_do_sleep(ctl_table * ctl,
> return 0;
> }
>
> -static int pm_do_suspend(ctl_table * ctl, int write, struct file *file,
> - void __user *buffer, size_t * len, loff_t *ppos)
> -{
> - if (!write) {
> - *len = 0;
> - } else {
> - suspend_mode = 1;
> - }
> - return 0;
> -}
> -
> -
> static int pm_do_freq(ctl_table * ctl, int write, struct file *file,
> void __user *buffer, size_t * len, loff_t *ppos)
> {
> @@ -408,14 +396,6 @@ static int pm_do_freq(ctl_table * ctl, i
>
> static struct ctl_table pm_table[] = {
> {
> - .ctl_name = CTL_UNNUMBERED,
> - .procname = "suspend",
> - .data = NULL,
> - .maxlen = 0,
> - .mode = 0600,
> - .proc_handler = &pm_do_suspend
> - },
> - {
> .ctl_name = CTL_UNNUMBERED,
> .procname = "sleep",
> .data = NULL,

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
pomozte zachranit klanovicky les: http://www.ujezdskystrom.info/