Re: [PATCH v4] UIO: Implement a UIO interface for the SMX Cryptengine

[Paul Mundt <lethal@linux-sh.org>]

On Thu, Mar 13, 2008 at 10:27:30PM +1100, Ben Nizette wrote:
> This patch implements a UIO interface for the SMX Cryptengine.
> 
> The Cryptengine found on the Nias Digital SMX board is best suited
> for a UIO interface.  It is not wired in to the cryptographic API
> as the engine handles it's own keys, algorithms, everything.  All
> that we know about is that if there's room in the buffer, you can
> write data to it and when there's data ready, you read it out again.
> 
> There isn't necessarily even any direct correlation between data
> going in and data coming out again, the engine may consume or
> generate data all on its own.
> 
> This driver is for proprietary hardware but we're always told to
> submit the drivers anyway; here you are.  :-)
> 
> This is version 4 of this patch and addresses all issues raised by
> Hans-J??rgen Koch and Paul Mundt in their reviews.  Slightly altered
> is Paul's suggestion to use DRV_NAME and DRV_VERSION as the UIO
> version and name.  While at the moment they are the same, there
> is no reason for them to stay that way.  Nevertheless we now at
> least provide a MODULE_VERSION macro to keep modinfo happy.
> 
Looks good to me.