From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754989AbYCMOTb (ORCPT ); Thu, 13 Mar 2008 10:19:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752133AbYCMOTY (ORCPT ); Thu, 13 Mar 2008 10:19:24 -0400 Received: from ftp.linux-mips.org ([194.74.144.162]:49758 "EHLO ftp.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751672AbYCMOTX (ORCPT ); Thu, 13 Mar 2008 10:19:23 -0400 Date: Thu, 13 Mar 2008 14:19:17 +0000 From: Ralf Baechle To: Pavel Machek Cc: Andrew Morton , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Ingo Molnar , Thomas Gleixner , David Howells Subject: Re: pm_register() and pm_send_all() Message-ID: <20080313141917.GA4117@linux-mips.org> References: <20080312150042.96668bcd.akpm@linux-foundation.org> <20080313092813.GA24027@elf.ucw.cz> <20080313122823.GA19415@linux-mips.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080313122823.GA19415@linux-mips.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 13, 2008 at 12:28:23PM +0000, Ralf Baechle wrote: > Looks correct to me, thus ACK. > > Spinning that a little further I wonder how useful the rest of the > Alchemy code - which seems to only deal with devices - is. If at all. > I'm going to check with some Alchemy users if that code actually works or > can be removed. I think the latter. Also there is the APM emulation > available which provides similar functionality. So here a patch do cleanup a part. Probably more to come From: Ralf Baechle [MIPS] Alchey: Crapectomy after removal of pm_send_all calls. Signed-off-by: Ralf Baechle arch/mips/au1000/common/power.c | 20 -------------------- 1 file changed, 20 deletions(-) Index: linux-mips/arch/mips/au1000/common/power.c =================================================================== --- linux-mips.orig/arch/mips/au1000/common/power.c +++ linux-mips/arch/mips/au1000/common/power.c @@ -283,18 +283,6 @@ static int pm_do_sleep(ctl_table * ctl, return 0; } -static int pm_do_suspend(ctl_table * ctl, int write, struct file *file, - void __user *buffer, size_t * len, loff_t *ppos) -{ - if (!write) { - *len = 0; - } else { - suspend_mode = 1; - } - return 0; -} - - static int pm_do_freq(ctl_table * ctl, int write, struct file *file, void __user *buffer, size_t * len, loff_t *ppos) { @@ -408,14 +396,6 @@ static int pm_do_freq(ctl_table * ctl, i static struct ctl_table pm_table[] = { { - .ctl_name = CTL_UNNUMBERED, - .procname = "suspend", - .data = NULL, - .maxlen = 0, - .mode = 0600, - .proc_handler = &pm_do_suspend - }, - { .ctl_name = CTL_UNNUMBERED, .procname = "sleep", .data = NULL,