From: Andrew Morton <akpm@linux-foundation.org>
To: "Yinghai Lu" <yhlu.kernel@gmail.com>
Cc: mingo@elte.hu, clameter@sgi.com, linux-kernel@vger.kernel.org,
ak@suse.de, y-goto@jp.fujitsu.com,
kamezawa.hiroyu@jp.fujitsu.com
Subject: Re: [PATCH] x86_64: free_bootmem should take phy
Date: Thu, 13 Mar 2008 15:04:41 -0700 [thread overview]
Message-ID: <20080313150441.014c96f9.akpm@linux-foundation.org> (raw)
In-Reply-To: <86802c440803131213i4e19002an859a3f3ffb109727@mail.gmail.com>
On Thu, 13 Mar 2008 12:13:23 -0700
"Yinghai Lu" <yhlu.kernel@gmail.com> wrote:
> [PATCH] x86_64: free_bootmem should take phys
>
> so use nodedata_phys directly.
>
> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
>
> diff --git a/arch/x86/mm/numa_64.c b/arch/x86/mm/numa_64.c
> index 0c9b2bd..18267a0 100644
> --- a/arch/x86/mm/numa_64.c
> +++ b/arch/x86/mm/numa_64.c
> @@ -221,8 +221,7 @@ void __init setup_node_bootmem(int nodeid, unsigned long start,
> bootmap_pages<<PAGE_SHIFT, PAGE_SIZE);
> if (bootmap == NULL) {
> if (nodedata_phys < start || nodedata_phys >= end)
> - free_bootmem((unsigned long)node_data[nodeid],
> - pgdat_size);
> + free_bootmem(nodedata_phys, pgdat_size);
> node_data[nodeid] = NULL;
> return;
> }
>
Can you please confirm that this change has no dependency upon your other
recent changes?
Thanks.
next prev parent reply other threads:[~2008-03-13 22:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-13 19:13 [PATCH] x86_64: free_bootmem should take phy Yinghai Lu
2008-03-13 22:04 ` Andrew Morton [this message]
2008-03-13 22:10 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080313150441.014c96f9.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@suse.de \
--cc=clameter@sgi.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=y-goto@jp.fujitsu.com \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox