From: Andrew Morton <akpm@linux-foundation.org>
To: David Brownell <david-b@pacbell.net>
Cc: linux-kernel@vger.kernel.org, avorontsov@ru.mvista.com
Subject: Re: [patch 2.6.25-rc5 2/2] gpiochip_reserve()
Date: Thu, 13 Mar 2008 16:06:06 -0700 [thread overview]
Message-ID: <20080313160606.219166f5.akpm@linux-foundation.org> (raw)
In-Reply-To: <200803131552.22122.david-b@pacbell.net>
On Thu, 13 Mar 2008 14:52:21 -0800
David Brownell <david-b@pacbell.net> wrote:
> +int __init __must_check gpiochip_reserve(int start, int ngpio)
I applaud the addition of __msut_check to a newly-added function of this
kind, but we usually only add the tag to the declaration, not to the
definition as well.
Not a lot of thought went into this, but we might as well be consistent.
--- a/drivers/gpio/gpiolib.c~gpiochip_reserve-fix
+++ a/drivers/gpio/gpiolib.c
@@ -121,7 +121,7 @@ static int gpiochip_find_base(int ngpio)
* to mark a range of gpios as unavailable for dynamic gpio number allocation,
* for example because its driver support is not yet loaded.
*/
-int __init __must_check gpiochip_reserve(int start, int ngpio)
+int __init gpiochip_reserve(int start, int ngpio)
{
int ret = 0;
unsigned long flags;
next prev parent reply other threads:[~2008-03-13 23:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-13 22:52 [patch 2.6.25-rc5 2/2] gpiochip_reserve() David Brownell
2008-03-13 23:06 ` Andrew Morton [this message]
2008-03-14 1:33 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080313160606.219166f5.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=avorontsov@ru.mvista.com \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox