From: Andrew Morton <akpm@linux-foundation.org>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@linux-foundation.org, hch@lst.de, dhowells@redhat.com,
marc.c.dionne@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] struct export_operations: adjust comments to match current members
Date: Fri, 14 Mar 2008 13:05:27 -0700 [thread overview]
Message-ID: <20080314130527.35c595eb.akpm@linux-foundation.org> (raw)
In-Reply-To: <22062.1205500289@redhat.com>
On Fri, 14 Mar 2008 13:11:29 +0000
David Howells <dhowells@redhat.com> wrote:
>
> From: "Marc Dionne" <marc.c.dionne@gmail.com>
>
> The comments in the definition of struct export_operations don't match the
> current members.
>
> Add a comment for the 2 new functions and remove 2 comments for unused ones.
>
> Signed-off-by: Marc Dionne <marc.c.dionne@gmail.com>
> Acked-by: David Howells <dhowells@redhat.com>
I changed this to Signed-off-by:. You were in the delivery path.
> ---
> include/linux/exportfs.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/exportfs.h b/include/linux/exportfs.h
> index 51d2141..adcbb05 100644
> --- a/include/linux/exportfs.h
> +++ b/include/linux/exportfs.h
> @@ -49,11 +49,11 @@ struct fid {
>
> /**
> * struct export_operations - for nfsd to communicate with file systems
> - * @decode_fh: decode a file handle fragment and return a &struct dentry
> * @encode_fh: encode a file handle fragment from a dentry
> + * @fh_to_dentry: find the implied object and get a dentry for it
> + * @fh_to_parent: find the implied object's parent and get a dentry for it
> * @get_name: find the name for a given inode in a given directory
> * @get_parent: find the parent of a given directory
> - * @get_dentry: find a dentry for the inode given a file handle
> sub-fragment
Someone is wordwrapping.
> *
> * See Documentation/filesystems/Exporting for details on how to use
> * this interface correctly.
prev parent reply other threads:[~2008-03-14 20:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-14 13:11 [PATCH] struct export_operations: adjust comments to match current members David Howells
2008-03-14 13:17 ` Christoph Hellwig
2008-03-14 20:05 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080314130527.35c595eb.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.c.dionne@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox