[PATCH] struct export_operations: adjust comments to match current members

[PATCH] struct export_operations: adjust comments to match current members

[David Howells]

From: "Marc Dionne" <marc.c.dionne@gmail.com>

The comments in the definition of struct export_operations don't match the
current members.

Add a comment for the 2 new functions and remove 2 comments for unused ones.

Signed-off-by: Marc Dionne <marc.c.dionne@gmail.com>
Acked-by: David Howells <dhowells@redhat.com>
---
 include/linux/exportfs.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/exportfs.h b/include/linux/exportfs.h
index 51d2141..adcbb05 100644
--- a/include/linux/exportfs.h
+++ b/include/linux/exportfs.h
@@ -49,11 +49,11 @@ struct fid {

 /**
  * struct export_operations - for nfsd to communicate with file systems
- * @decode_fh:      decode a file handle fragment and return a &struct dentry
  * @encode_fh:      encode a file handle fragment from a dentry
+ * @fh_to_dentry:   find the implied object and get a dentry for it
+ * @fh_to_parent:   find the implied object's parent and get a dentry for it
  * @get_name:       find the name for a given inode in a given directory
  * @get_parent:     find the parent of a given directory
- * @get_dentry:     find a dentry for the inode given a file handle
sub-fragment
  *
  * See Documentation/filesystems/Exporting for details on how to use
  * this interface correctly.

Re: [PATCH] struct export_operations: adjust comments to match current members

[Christoph Hellwig]

On Fri, Mar 14, 2008 at 01:11:29PM +0000, David Howells wrote:
> 
> From: "Marc Dionne" <marc.c.dionne@gmail.com>
> 
> The comments in the definition of struct export_operations don't match the
> current members.
> 
> Add a comment for the 2 new functions and remove 2 comments for unused ones.
> 
> Signed-off-by: Marc Dionne <marc.c.dionne@gmail.com>
> Acked-by: David Howells <dhowells@redhat.com>

ACK.

Re: [PATCH] struct export_operations: adjust comments to match current members

[Andrew Morton]

On Fri, 14 Mar 2008 13:11:29 +0000
David Howells <dhowells@redhat.com> wrote:

> 
> From: "Marc Dionne" <marc.c.dionne@gmail.com>
> 
> The comments in the definition of struct export_operations don't match the
> current members.
> 
> Add a comment for the 2 new functions and remove 2 comments for unused ones.
> 
> Signed-off-by: Marc Dionne <marc.c.dionne@gmail.com>
> Acked-by: David Howells <dhowells@redhat.com>

I changed this to Signed-off-by:.  You were in the delivery path.

> ---
>  include/linux/exportfs.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/exportfs.h b/include/linux/exportfs.h
> index 51d2141..adcbb05 100644
> --- a/include/linux/exportfs.h
> +++ b/include/linux/exportfs.h
> @@ -49,11 +49,11 @@ struct fid {
> 
>  /**
>   * struct export_operations - for nfsd to communicate with file systems
> - * @decode_fh:      decode a file handle fragment and return a &struct dentry
>   * @encode_fh:      encode a file handle fragment from a dentry
> + * @fh_to_dentry:   find the implied object and get a dentry for it
> + * @fh_to_parent:   find the implied object's parent and get a dentry for it
>   * @get_name:       find the name for a given inode in a given directory
>   * @get_parent:     find the parent of a given directory
> - * @get_dentry:     find a dentry for the inode given a file handle
> sub-fragment

Someone is wordwrapping.

>   *
>   * See Documentation/filesystems/Exporting for details on how to use
>   * this interface correctly.