public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Carlo Wood <carlo@alinoe.com>,
	ext3grep@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [ext3grep] compile error
Date: Fri, 14 Mar 2008 16:55:19 -0400	[thread overview]
Message-ID: <20080314205519.GE13733@mit.edu> (raw)
In-Reply-To: <20080314181455.GA15351@infradead.org>

On Fri, Mar 14, 2008 at 02:14:55PM -0400, Christoph Hellwig wrote:
> On Fri, Mar 14, 2008 at 06:00:04PM +0100, Carlo Wood wrote:
> > This seem a bug in linux/ext3_fs.h. I was able to reproduce this on
> > debian sid, meaning kernel (headers) 2.6.24.
> 
> No, the problem is that the tool you're compiling is using kernel
> headers which it shouldn't use at all.  Please use the headers from
> e2fslibs-dev in /usr/include/esxt2fs/ instead.  And yes, they provide
> ext3 defintions despite the ext2 name.

Furthermore, applications are well advised to use libext2fs instead of
trying to roll their own access routines.  Libext2fs has been in
development for over ten years, and as such as all sorts of nice
features, including regression test suites, byte swapping so the code
will work on big-endian systems, portability to non-Linux systems, etc.

Using libext2fs also means that it's much more likely the application
will require less work to support ext4 in the future.  If there's
something that ext3grep needs where some existing libext2fs function
provides almost, but not quite, the needed functionality, talk to me;
right now there's quite a bit of development going on with e2fsprogs,
and it's likely I can add the needed support in the next version of
the library.

Regards,

						- Ted

      reply	other threads:[~2008-03-14 20:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1f45affd0803140826m34d9eee5veb8069e215d55fcf@mail.gmail.com>
2008-03-14 17:00 ` [ext3grep] compile error Carlo Wood
2008-03-14 18:14   ` Christoph Hellwig
2008-03-14 20:55     ` Theodore Tso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080314205519.GE13733@mit.edu \
    --to=tytso@mit.edu \
    --cc=carlo@alinoe.com \
    --cc=ext3grep@googlegroups.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox