From: Jay Cliburn <jcliburn@gmail.com>
To: Julia Lawall <julia@diku.dk>
Cc: csnook@redhat.com, atl1-devel@lists.sourceforge.net,
jgarzik@pobox.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 7/7] drivers/net/atl1/atl1_main.c: remove unused variable
Date: Sat, 15 Mar 2008 17:16:09 -0500 [thread overview]
Message-ID: <20080315171609.05db507b@osprey.hogchain.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0803151704400.24178@ask.diku.dk>
On Sat, 15 Mar 2008 17:05:02 +0100 (CET)
Julia Lawall <julia@diku.dk> wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The variable update_rx is initialized but never used otherwise.
>
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @@
> type T;
> identifier i;
> constant C;
> @@
>
> (
> extern T i;
> |
> - T i;
> <+... when != i
> - i = C;
> ...+>
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Jay Cliburn <jacliburn@bellsouth.net>
> ---
> drivers/net/atl1/atl1_main.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff -u -p a/drivers/net/atl1/atl1_main.c
> b/drivers/net/atl1/atl1_main.c ---
> a/drivers/net/atl1/atl1_main.c 2008-03-12 14:13:13.000000000
> +0100 +++ b/drivers/net/atl1/atl1_main.c 2008-03-15
> 16:18:08.000000000 +0100 @@ -1765,15 +1765,12 @@ static irqreturn_t
> atl1_intr(int irq, vo { struct atl1_adapter *adapter =
> netdev_priv(data); u32 status;
> - u8 update_rx;
> int max_ints = 10;
>
> status = adapter->cmb.cmb->int_stats;
> if (!status)
> return IRQ_NONE;
>
> - update_rx = 0;
> -
> do {
> /* clear CMB interrupt status at once */
> adapter->cmb.cmb->int_stats = 0;
next prev parent reply other threads:[~2008-03-15 22:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-15 16:05 [PATCH 7/7] drivers/net/atl1/atl1_main.c: remove unused variable Julia Lawall
2008-03-15 22:16 ` Jay Cliburn [this message]
2008-03-17 11:58 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080315171609.05db507b@osprey.hogchain.net \
--to=jcliburn@gmail.com \
--cc=atl1-devel@lists.sourceforge.net \
--cc=csnook@redhat.com \
--cc=jgarzik@pobox.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox