From: Kyle McMartin <kyle@mcmartin.ca>
To: "S.?a??lar Onur" <caglar@pardus.org.tr>
Cc: linux-kernel@vger.kernel.org, Kyle McMartin <kyle@mcmartin.ca>,
linux-parisc@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] arch/parisc/kernel/unaligned.c: Use time_* macros
Date: Mon, 17 Mar 2008 11:40:57 -0400 [thread overview]
Message-ID: <20080317154057.GD3904@phobos.i.cabal.ca> (raw)
In-Reply-To: <1205746593-24820-3-git-send-email-caglar@pardus.org.tr>
Hi,
On Mon, Mar 17, 2008 at 11:36:25AM +0200, S.?a??lar Onur wrote:
Sorry, I seem to be losing at charsets with your name. :(
> The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values.
>
> So following patch implements usage of the time_after() macro, defined at linux/jiffies.h, which deals with wrapping correctly
>
I prefer the idea of using printk_ratelimit. I've committed a patch that
does this to git and credited you with pointing it out.
cheers, Kyle
> Cc: Kyle McMartin <kyle@mcmartin.ca>
> Cc: linux-parisc@vger.kernel.org
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: S.Ça??lar Onur <caglar@pardus.org.tr>
> ---
> arch/parisc/kernel/unaligned.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/parisc/kernel/unaligned.c b/arch/parisc/kernel/unaligned.c
> index aebf3c1..19b8a79 100644
> --- a/arch/parisc/kernel/unaligned.c
> +++ b/arch/parisc/kernel/unaligned.c
> @@ -460,7 +460,7 @@ void handle_unaligned(struct pt_regs *regs)
> goto force_sigbus;
> }
>
> - if (unaligned_count > 5 && jiffies - last_time > 5*HZ) {
> + if (unaligned_count > 5 && time_after(jiffies, last_time + 5 * HZ)) {
> unaligned_count = 0;
> last_time = jiffies;
> }
> --
> 1.5.4.3
>
next prev parent reply other threads:[~2008-03-17 15:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-17 9:36 [PATCH] arch/alpha/kernel/traps.c: Use time_* macros S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] arch/ia64/kernel/: " S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] arch/parisc/kernel/unaligned.c: " S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] arch/powerpc/platforms/iseries/pci.c: " S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] drivers/net/arcnet/arcnet.c: " S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] drivers/net/ax88796.c: " S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] net/mac80211/: " S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] drivers/net/tokenring/3c359.c: " S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] drivers/net/wireless/atmel.c: " S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] fs/binfmt_aout.c: Use printk_ratelimit() S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] Fix indentation S.Çağlar Onur
2008-03-25 18:32 ` [PATCH] net/mac80211/: Use time_* macros John W. Linville
2008-03-17 23:31 ` [PATCH] arch/powerpc/platforms/iseries/pci.c: " Stephen Rothwell
2008-03-17 15:40 ` Kyle McMartin [this message]
2008-03-17 9:59 ` [PATCH] arch/ia64/kernel/: " KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080317154057.GD3904@phobos.i.cabal.ca \
--to=kyle@mcmartin.ca \
--cc=akpm@linux-foundation.org \
--cc=caglar@pardus.org.tr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox