public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Gabriel C <nix.or.die@googlemail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Zhang Rui <rui.zhang@intel.com>, Len Brown <len.brown@intel.com>
Subject: Re: Linux 2.6.25-rc6
Date: Mon, 17 Mar 2008 19:39:41 +0100	[thread overview]
Message-ID: <20080317193941.6f247ea1@hyperion.delvare> (raw)
In-Reply-To: <47DE815C.4060906@googlemail.com>

Hi Gabriel,

On Mon, 17 Mar 2008 15:34:04 +0100, Gabriel C wrote:
> Linus Torvalds wrote:
> 
> > Zhang, Rui (2):
> >       thermal: fix generic thermal I/F for hwmon
> 
> That commit broke lmsensros here ( found by bisect ). 
> ...
> 
> Can't access procfs/sysfs file
> Kernel interface access error
> For 2.6 kernels, make sure you have mounted sysfs and libsensors
> was compiled with sysfs support!
> 
> ...
> 
> Of course proc and sysfs is mounted and the lib has that support :)

This has been reported as:
http://bugzilla.kernel.org/show_bug.cgi?id=10259
https://bugzilla.redhat.com/show_bug.cgi?id=437637

The generic thermal zone device does something which is not
fundamentally incorrect but that libsensors doesn't expect, and
unfortunately libsensors was not made robust enough and dies instead of
just ignoring the new unexpected device. libsensors 2.10.x is already
fixed in lm-sensors' SVN [1] and a tentative patch is available for
libsensors 3.0.x [2], however I am worried that kernel 2.6.25 will be
released before any new version of lm-sensors so pretty much every user
of lm-sensors will hit the problem if they upgrade to the new kernel.
For this reason, I think we really should let the new generic thermal
zone driver build as a module, and make it's hwmon support optional and
disabled by default for 2.6.25 [3]. This will help mitigate the risk of
massive breakage and complaints.

[1] http://www.lm-sensors.org/changeset/5147
[2] https://bugzilla.redhat.com/attachment.cgi?id=298270
[3] http://lists.lm-sensors.org/pipermail/lm-sensors/2008-March/022724.html

-- 
Jean Delvare

  reply	other threads:[~2008-03-17 19:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-17  0:01 Linux 2.6.25-rc6 Linus Torvalds
2008-03-17 14:34 ` Gabriel C
2008-03-17 18:39   ` Jean Delvare [this message]
2008-03-17 19:35     ` Gabriel C
2008-03-17 20:33       ` Jean Delvare
2008-03-18  4:57         ` Len Brown
2008-03-20  7:43 ` [BUG] Linux 2.6.25-rc6 - kernel BUG at fs/mpage.c:476! on powerpc Kamalesh Babulal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080317193941.6f247ea1@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nix.or.die@googlemail.com \
    --cc=rui.zhang@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox