public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Thomas Meyer <thomas@m3y3r.de>
Cc: Kristen Carlson Accardi <kristen.c.accardi@intel.com>,
	linux-acpi@vger.kernel.org, Adrian Bunk <bunk@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	htejun@gmail.com, jeff@garzik.org
Subject: [PATCH] Re: In function `ata_acpi_associate': undefined reference to	`register_hotplug_dock_device'
Date: Tue, 18 Mar 2008 00:11:48 -0400	[thread overview]
Message-ID: <200803180011.49190.lenb@kernel.org> (raw)
In-Reply-To: <200803172357.54253.lenb@kernel.org>

Subject: fix ATA_ACPI build
From: Len Brown <len.brown@intel.com>

drivers/ata/libata-acpi.c fails to build

drivers/built-in.o: In function `ata_acpi_associate':
(.text+0x7106a): undefined reference to `register_hotplug_dock_device'

When CONFIG_ATA_ACPI=y and CONFIG_ACPI_DOCK=m
But if dock is selected from ata_acpi, dock will =y
when ata_acpi=y, avoiding this problem.

Signed-off-by: Len Brown <len.brown@intel.com>

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index e469647..25aba69 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -30,6 +30,7 @@ config ATA_NONSTANDARD
 config ATA_ACPI
 	bool
 	depends on ACPI && PCI
+	select ACPI_DOCK
 	default y
 	help
 	  This option adds support for ATA-related ACPI objects.

  reply	other threads:[~2008-03-18  4:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-17 19:41 In function `ata_acpi_associate': undefined reference to `register_hotplug_dock_device' Thomas Meyer
2008-03-17 19:48 ` Adrian Bunk
2008-03-17 19:58   ` Thomas Meyer
2008-03-18  3:57     ` Len Brown
2008-03-18  4:11       ` Len Brown [this message]
2008-03-18  6:16         ` [PATCH] " Tejun Heo
2008-03-17 20:30 ` [2.6.25 patch] acpi_drivers.h: fix dock dummy functions Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803180011.49190.lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=bunk@kernel.org \
    --cc=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=kristen.c.accardi@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thomas@m3y3r.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox