From: Arnd Bergmann <arnd@arndb.de>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: tick-common.c hack for s390 needed
Date: Wed, 19 Mar 2008 05:12:57 +0100 [thread overview]
Message-ID: <200803190512.58703.arnd@arndb.de> (raw)
In-Reply-To: <20080318093119.GA8669@osiris.boeblingen.de.ibm.com>
On Tuesday 18 March 2008, Heiko Carstens wrote:
> Actually there's a huge #ifndef CONFIG_S390 in linux/irq.h ;)
>
> To make the code work the patch below is necessary. It's ok since all
> clock event devices on s390 are per cpu. However I think this patch is
> ugly at best. Any ideas how to fix this in a better and more generic way?
You could have an #else path in linux/irq.h to just define these
functions as s390, maybe like
static inline int irq_set_affinity(unsigned int irq, cpumask_t cpumask)
{
BUG();
return 0;
}
static inline int irq_can_set_affinity(unsigned int irq)
{
return 0;
}
Arnd <><
next prev parent reply other threads:[~2008-03-19 23:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-18 9:31 tick-common.c hack for s390 needed Heiko Carstens
2008-03-19 4:12 ` Arnd Bergmann [this message]
2008-03-19 5:45 ` Christoph Hellwig
2008-03-21 10:15 ` Ingo Molnar
2008-03-21 13:25 ` Heiko Carstens
2008-03-21 14:45 ` Thomas Gleixner
2008-03-22 20:32 ` Heiko Carstens
2008-03-23 22:34 ` Russell King
2008-03-24 10:14 ` Heiko Carstens
2008-03-25 19:09 ` Thomas Gleixner
2008-03-25 19:30 ` Russell King
2008-04-01 11:02 ` Heiko Carstens
2008-04-01 11:24 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803190512.58703.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox