From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg KH <greg@kroah.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux-pm mailing list <linux-pm@lists.linux-foundation.org>,
Kernel development list <linux-kernel@vger.kernel.org>,
lenb@kernel.org
Subject: Re: + pm-convert-wakeup-flag-accessors-to-inline-functions-fix.patch added to -mm tree
Date: Wed, 19 Mar 2008 22:55:28 +0100 [thread overview]
Message-ID: <200803192255.29655.rjw@sisk.pl> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0803191736550.2504-100000@netrider.rowland.org>
On Wednesday, 19 of March 2008, Alan Stern wrote:
> On Wed, 19 Mar 2008, Greg KH wrote:
>
> > On Wed, Mar 19, 2008 at 11:48:29AM -0700, Andrew Morton wrote:
> > > I'll drop everything, let's start again.
> > >
> > > Only how? umm, please review Greg's driver tree, let us know which patches
> > > shoudl be dropped from that then send new ones, I guess.
> >
> > Yes, please do, I'm confused as well :)
>
> Okay. No doubt Rafael will correct me if I get something wrong.
>
> Greg's tree still contains the original, wrong version of
> pm-make-wakeup-flags-available-whenever-config_pm-is-set.patch. It
> should be reverted. In its place should be substituted this series of
> patches (URLs for 0/3 ... 3/3):
>
> http://marc.info/?l=linux-kernel&m=120561808422302&w=2
> http://marc.info/?l=linux-kernel&m=120561808522316&w=2
> http://marc.info/?l=linux-kernel&m=120561808522322&w=2
> http://marc.info/?l=linux-kernel&m=120561808622328&w=2
>
> There is likely to be a conflict in applying the 2/3 patch, because its
> first hunk touches a region of code also affected by work Rafael has
> been doing. The important aspect of that hunk is that it moves the
> should_wakeup flag definition outside the region protected by "#ifdef
> CONFIG_PM_SLEEP".
I've just resent the three patches, rebased on top of the current tree.
Please double check if everytning is right.
Thanks,
Rafael
next prev parent reply other threads:[~2008-03-19 23:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200803190315.m2J3FXnK029022@imap1.linux-foundation.org>
2008-03-19 14:55 ` + pm-convert-wakeup-flag-accessors-to-inline-functions-fix.patch added to -mm tree Alan Stern
2008-03-19 18:48 ` Andrew Morton
2008-03-19 18:57 ` Greg KH
2008-03-19 21:33 ` [PATCH 0/3] PM wakeup flags revisited (was: Re: + pm-convert-wakeup-flag-accessors-to-inline-functions-fix.patch added to -mm tree) Rafael J. Wysocki
2008-03-19 21:35 ` [PATCH 1/3] Fix misuse of wakeup flag accessors in serial core Rafael J. Wysocki
2008-03-20 23:23 ` patch pm-fix-misuse-of-wakeup-flag-accessors-in-serial-core.patch added to gregkh-2.6 tree gregkh
2008-03-19 21:37 ` [PATCH 2/3] PM: Make wakeup flags available whenever CONFIG_PM is set (ver 2) Rafael J. Wysocki
2008-03-19 22:22 ` [linux-pm] " David Brownell
2008-03-20 23:23 ` patch pm-make-wakeup-flags-available-whenever-config_pm-is-set.patch added to gregkh-2.6 tree gregkh
2008-03-19 21:39 ` [PATCH 3/3] PM: Convert wakeup flag accessors to inline functions Rafael J. Wysocki
2008-03-20 23:23 ` patch pm-convert-wakeup-flag-accessors-to-inline-functions.patch added to gregkh-2.6 tree gregkh
2008-03-19 21:46 ` + pm-convert-wakeup-flag-accessors-to-inline-functions-fix.patch added to -mm tree Alan Stern
2008-03-19 21:55 ` Rafael J. Wysocki [this message]
2008-03-19 22:04 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803192255.29655.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox