Re: [PATCH 1/3 v3] dma: document dma_{un}map_{single|sg}_attrs() interface

Michael Ellerman
2008-03-06T06:01:57Z

[-- Attachment #1: Type: text/plain, Size: 2098 bytes --]

On Wed, 2008-03-05 at 10:13 -0800, akepner@sgi.com wrote:
> On Fri, Feb 29, 2008 at 12:37:56PM -0600, James Bottomley wrote:
> > ....
> > To be honest, I still don't like the name. SYNC_ON_WRITE is the SN2
> > implementation. What it's actually doing is implementing strict
> > ordering semantics. I think it should really be
> > DMA_ATTR_STRICT_ORDERING (with a corresponding
> > DMA_ATTR_RELAXED_ORDERING)....
>
> I've been thinking about a new name, but don't like
> DMA_ATTR_STRICT_ORDERING.
>
> What I'm trying to do is to establish order (across
> a NUMA fabric) of DMA to different memory regions, i.e.,
> DMA to memory region A forces all outstanding DMA (to
> memory regions B, C,....) to complete first.
>
> DMA_ATTR_STRICT_ORDERING sounds like a PCI thing to me,
> and this is a NUMA interconnect thing.

It's not a matter of whether it's a PCI thing or a NUMA thing. The name
of the attribute needs to reflect the semantics of what the driver
perceives, along the entire path from the device including PCI and NUMA
and other bits.

How the attribute is implemented is up to the arch code, it can decide
if it sets attributes on the PHB or the device or in the NUMA
interconnect or whatever.

For a single mapping, it's fairly straight forward to define two obvious
cases:
- strict ordering, all accesses to this mapping are ordered.
- weak ordering (none, relaxed ..) - accesses to this mapping are not
ordered in anyway.

Where I think it gets confusing is the semantics between mappings with
different attributes. If I map region A weak and then region B strict,
does an access to region B have any effect on accesses to region A?

It sounds like in your case the answer is yes - but I don't know if
that's clearly the right answer.

/me scratches his head :)

cheers

--
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]