public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	Jon Masters <jcm@jonmasters.org>,
	"Frank Ch. Eigler" <fche@redhat.com>,
	Jon Masters <jcm@redhat.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Christoph Hellwig <hch@infradead.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [patch 4/4] Markers Support for Proprierary Modules
Date: Thu, 20 Mar 2008 04:38:39 -0400	[thread overview]
Message-ID: <20080320083839.GA3569@infradead.org> (raw)
In-Reply-To: <20080320002835.384758480@polymtl.ca>

On Wed, Mar 19, 2008 at 08:27:41PM -0400, Mathieu Desnoyers wrote:
> There seems to be good arguments for markers to support proprierary modules. So
> I am throwing this one-liner in and let's see how people react. It only makes
> sure that a module that has been "forced" to be loaded won't have its markers
> used. It is important to leave this check to make sure the kernel does not crash
> by expecting the markers part of the struct module by mistake in the case there
> is an incorrect checksum.

I still disagree.  Markers are per defintion a very linux specific API
and thus should stay internal.


  parent reply	other threads:[~2008-03-20  8:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-20  0:27 [patch 0/4] Markers updates for 2.6.25-rc6 Mathieu Desnoyers
2008-03-20  0:27 ` [patch 1/4] Markers - depends on not PREEMPT_RCU Mathieu Desnoyers
2008-03-20 19:03   ` Ingo Molnar
2008-03-20 19:49     ` Paul E. McKenney
2008-03-20  0:27 ` [patch 2/4] Markers - Update preempt_disable. call_rcu, rcu_barrier comments Mathieu Desnoyers
2008-03-20  0:27 ` [patch 3/4] Markers - Remove ACCESS_ONCE Mathieu Desnoyers
2008-03-20  0:27 ` [patch 4/4] Markers Support for Proprierary Modules Mathieu Desnoyers
2008-03-20  5:35   ` Rusty Russell
2008-03-20 12:30     ` Mathieu Desnoyers
2008-03-20  8:38   ` Christoph Hellwig [this message]
2008-03-20 19:12   ` Ingo Molnar
2008-03-20 19:18     ` Jon Masters
2008-03-20 22:15       ` Ingo Molnar
2008-03-20 20:17     ` Frank Ch. Eigler
2008-03-20 22:05       ` Ingo Molnar
2008-03-20 22:24         ` Mathieu Desnoyers
2008-03-20 22:22     ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080320083839.GA3569@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=fche@redhat.com \
    --cc=jcm@jonmasters.org \
    --cc=jcm@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=rusty@rustcorp.com.au \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox