Re: [patch 4/4] Markers Support for Proprierary Modules

Christoph Hellwig
2008-03-20T08:38:59Z

On Wed, Mar 19, 2008 at 08:27:41PM -0400, Mathieu Desnoyers wrote:
> There seems to be good arguments for markers to support proprierary modules. So
> I am throwing this one-liner in and let's see how people react. It only makes
> sure that a module that has been "forced" to be loaded won't have its markers
> used. It is important to leave this check to make sure the kernel does not crash
> by expecting the markers part of the struct module by mistake in the case there
> is an incorrect checksum.

I still disagree. Markers are per defintion a very linux specific API
and thus should stay internal.