public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	Jon Masters <jcm@jonmasters.org>,
	"Frank Ch. Eigler" <fche@redhat.com>,
	Jon Masters <jcm@redhat.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Christoph Hellwig <hch@infradead.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [patch 4/4] Markers Support for Proprierary Modules
Date: Thu, 20 Mar 2008 20:12:05 +0100	[thread overview]
Message-ID: <20080320191205.GA13309@elte.hu> (raw)
In-Reply-To: <20080320002835.384758480@polymtl.ca>


* Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:

> There seems to be good arguments for markers to support proprierary 
> modules. So I am throwing this one-liner in and let's see how people 
> react. [...]

ugh, this is unbelievably stupid move technically - so a very strong 
NACK. Allowing marker use in unfixable modules (today it's placing 
markers into unfixable modules, tomorrow it's marker use by such 
modules) has only one clear and predictable effect: it turns marker 
calls into essential ABIs because when faced with any breakage in an 
unfixable module that makes use of a marker in some kernel subsystem 
then all the pressure is on those who _can_ fix their code - meaning the 
kernel subsystem maintainers that use markers.

unfixable modules should only be allowed access to easy things they can 
access anyway, or to such fundamental things which we wont realistically 
change anyway. Markers are neither.

(i also find it puzzling why you go out on a limb helping a piece of 
_irrelevant_ technology that has been the unparalleled source of pain 
and anguish to both kernel users and kernel developers.)

	Ingo

  parent reply	other threads:[~2008-03-20 19:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-20  0:27 [patch 0/4] Markers updates for 2.6.25-rc6 Mathieu Desnoyers
2008-03-20  0:27 ` [patch 1/4] Markers - depends on not PREEMPT_RCU Mathieu Desnoyers
2008-03-20 19:03   ` Ingo Molnar
2008-03-20 19:49     ` Paul E. McKenney
2008-03-20  0:27 ` [patch 2/4] Markers - Update preempt_disable. call_rcu, rcu_barrier comments Mathieu Desnoyers
2008-03-20  0:27 ` [patch 3/4] Markers - Remove ACCESS_ONCE Mathieu Desnoyers
2008-03-20  0:27 ` [patch 4/4] Markers Support for Proprierary Modules Mathieu Desnoyers
2008-03-20  5:35   ` Rusty Russell
2008-03-20 12:30     ` Mathieu Desnoyers
2008-03-20  8:38   ` Christoph Hellwig
2008-03-20 19:12   ` Ingo Molnar [this message]
2008-03-20 19:18     ` Jon Masters
2008-03-20 22:15       ` Ingo Molnar
2008-03-20 20:17     ` Frank Ch. Eigler
2008-03-20 22:05       ` Ingo Molnar
2008-03-20 22:24         ` Mathieu Desnoyers
2008-03-20 22:22     ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080320191205.GA13309@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=fche@redhat.com \
    --cc=hch@infradead.org \
    --cc=jcm@jonmasters.org \
    --cc=jcm@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=rusty@rustcorp.com.au \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox