From: Ingo Molnar <mingo@elte.hu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: tick-common.c hack for s390 needed
Date: Fri, 21 Mar 2008 11:15:04 +0100 [thread overview]
Message-ID: <20080321101504.GI20420@elte.hu> (raw)
In-Reply-To: <20080319054545.GA18834@infradead.org>
* Christoph Hellwig <hch@infradead.org> wrote:
> On Tue, Mar 18, 2008 at 10:31:19AM +0100, Heiko Carstens wrote:
> > Hi Thomas, Ingo,
> >
> > I'm converting s390 from s390's NO_IDLE_HZ to GENERIC_CLOCKEVENTS and
> > therefore to the generic NO_HZ implementation.
> > One of the problems that need a patch for this is kernel/time/tick-common.c
> > which relies on the irq stuff present in include/linux/irq.h.
> > In particular s390 doesn't have something like irq_set_affinity which
> > causes this build error:
>
> Generic code must never use linux/irq.h - it's more like asm-generic
> file predating asm-generic.
agreed.
Heiko, if you remove all these:
./time/tick-broadcast.c:#include <linux/irq.h>
./time/tick-oneshot.c:#include <linux/irq.h>
./time/tick-common.c:#include <linux/irq.h>
./hrtimer.c:#include <linux/irq.h>
from kernel/*, do things improve on s390? If yes then please send a
patch for it and i'll check whether there's any include file dependency
fallout on x86.
Ingo
next prev parent reply other threads:[~2008-03-21 10:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-18 9:31 tick-common.c hack for s390 needed Heiko Carstens
2008-03-19 4:12 ` Arnd Bergmann
2008-03-19 5:45 ` Christoph Hellwig
2008-03-21 10:15 ` Ingo Molnar [this message]
2008-03-21 13:25 ` Heiko Carstens
2008-03-21 14:45 ` Thomas Gleixner
2008-03-22 20:32 ` Heiko Carstens
2008-03-23 22:34 ` Russell King
2008-03-24 10:14 ` Heiko Carstens
2008-03-25 19:09 ` Thomas Gleixner
2008-03-25 19:30 ` Russell King
2008-04-01 11:02 ` Heiko Carstens
2008-04-01 11:24 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080321101504.GI20420@elte.hu \
--to=mingo@elte.hu \
--cc=hch@infradead.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox