From: Ingo Molnar <mingo@elte.hu>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Pavel Machek <pavel@ucw.cz>, Jiri Slaby <jirislaby@gmail.com>,
mingo@redhat.com, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] Mark early_printk as asmlinkage
Date: Fri, 21 Mar 2008 13:25:05 +0100 [thread overview]
Message-ID: <20080321122505.GH25225@elte.hu> (raw)
In-Reply-To: <47DAC66D.2000902@zytor.com>
* H. Peter Anvin <hpa@zytor.com> wrote:
>> I'd call asmlinkage kind of documentation, then. Not everyone is as
>> good with x86 abi as you are...
>
> Since it's already only used on x86-32 and we no longer support
> non-regparm x86, I'd like to at least get to the point where x86-32
> doesn't have any function. We can retain it for documentation's sake,
> but even then it's iffy... is "this is callable from assembly" really
> something arch-invariant.
the kernel still works if we disable regparm, and it makes sense to just
have a good list of all functions that are called from assembly. But
it's not just about non-regparm or documentation, we have regular
trouble with over-eager gcc optimizations that assume that all code is
generated by gcc ... Furthermore, code flow is easier to understand if
we know what is called from assembly and what not. So documenting all
these places makes sense to me and we've applied similar patches in the
past.
Ingo
next prev parent reply other threads:[~2008-03-21 12:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 13:53 [PATCH] Arch: x86_32, fix fault_msg nul termination Jiri Slaby
2008-03-12 13:53 ` [PATCH] Mark early_printk as asmlinkage Jiri Slaby
2008-03-12 14:04 ` H. Peter Anvin
2008-03-12 14:07 ` Jiri Slaby
2008-03-12 14:21 ` H. Peter Anvin
2008-03-14 18:04 ` Pavel Machek
2008-03-14 18:39 ` H. Peter Anvin
2008-03-21 12:25 ` Ingo Molnar [this message]
2008-03-21 11:50 ` [PATCH] Arch: x86_32, fix fault_msg nul termination Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080321122505.GH25225@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox