From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757831AbYCUOyT (ORCPT ); Fri, 21 Mar 2008 10:54:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754729AbYCUOyI (ORCPT ); Fri, 21 Mar 2008 10:54:08 -0400 Received: from relay1.sgi.com ([192.48.171.29]:57444 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753805AbYCUOyH (ORCPT ); Fri, 21 Mar 2008 10:54:07 -0400 Date: Fri, 21 Mar 2008 09:54:03 -0500 From: Jack Steiner To: Ingo Molnar Cc: ak@suse.de, tglx@linutronix.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] - Allow NODES_SHIFT to be a config option on x86_64 Message-ID: <20080321145401.GA10303@sgi.com> References: <20080321133425.GA11095@sgi.com> <20080321142648.GB31719@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080321142648.GB31719@elte.hu> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 21, 2008 at 03:26:49PM +0100, Ingo Molnar wrote: > > * Jack Steiner wrote: > > > Allow the maximum number of nodes in an x86_64 system to be > > configurable. This patch does NOT change the default value but allows > > the value to be a config option. > > i've applied your patch - but i'm wondering, shouldnt we auto-scale the > default according to max number of CPUs? (with some sensible scaling > that happens to meet your expected large-system needs as well ;-) All > the current manual configuration of nodes shift is ugly. I would prefer to auto-scale, too, but our hardware platform allows too many options to make it easy. The current system configs will support from 0 to 32 cpus per node (some nodes have memory only). However, I'm open to suggestions if you have any ideas.... --- jack