From: Andrew Morton <akpm@linux-foundation.org>
To: Libor Pechacek <lpechacek@suse.cz>
Cc: fubar@us.ibm.com, bonding-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
stable@kernel.org
Subject: Re: [PATCH] bonding: Fix sysfs attribute handling
Date: Sat, 22 Mar 2008 17:27:04 -0700 [thread overview]
Message-ID: <20080322172704.49fa557b.akpm@linux-foundation.org> (raw)
In-Reply-To: <200803211452.55982.lpechacek@suse.cz>
On Fri, 21 Mar 2008 14:52:55 +0100 Libor Pechacek <lpechacek@suse.cz> wrote:
> bonding: Fix sysfs attribute handling
>
> For bonding interfaces any attempt to read the sysfs directory contents after
> module removal results in an oops. The fix is to release sysfs attributes
> for the interfaces upon module unload.
>
> Signed-off-by: Libor Pechacek <lpechacek@suse.cz>
> --
> drivers/net/bonding/bond_main.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 0942d82..33767d4 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -4528,8 +4528,7 @@ static void bond_free_all(void)
> netif_tx_unlock_bh(bond_dev);
> /* Release the bonded slaves */
> bond_release_all(bond_dev);
> - bond_deinit(bond_dev);
> - unregister_netdevice(bond_dev);
> + bond_destroy(bond);
> }
Is this also needed in 2.6.24.x?
next prev parent reply other threads:[~2008-03-23 0:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-21 13:52 [PATCH] bonding: Fix sysfs attribute handling Libor Pechacek
2008-03-23 0:27 ` Andrew Morton [this message]
2008-03-23 1:12 ` Jay Vosburgh
2008-03-23 20:05 ` lpechacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080322172704.49fa557b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bonding-devel@lists.sourceforge.net \
--cc=fubar@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lpechacek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox