From: Venki Pallipadi <venkatesh.pallipadi@intel.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: venkatesh.pallipadi@intel.com, ak@muc.de, ebiederm@xmission.com,
rdreier@cisco.com, torvalds@linux-foundation.org, gregkh@suse.de,
airlied@skynet.ie, davej@redhat.com, mingo@elte.hu,
tglx@linutronix.de, hpa@zytor.com, akpm@linux-foundation.org,
arjan@infradead.org, jesse.barnes@intel.com,
linux-kernel@vger.kernel.org,
Suresh Siddha <suresh.b.siddha@intel.com>
Subject: Re: [patch 02/13] x86: PAT infrastructure patch
Date: Mon, 24 Mar 2008 14:22:35 -0700 [thread overview]
Message-ID: <20080324212235.GA6783@linux-os.sc.intel.com> (raw)
In-Reply-To: <20080319130639.819777b7.randy.dunlap@oracle.com>
On Wed, Mar 19, 2008 at 01:06:39PM -0700, Randy Dunlap wrote:
> On Tue, 18 Mar 2008 17:00:14 -0700 venkatesh.pallipadi@intel.com wrote:
>
> diffstat would be very nice to have.
I have updated my quilt scripts to auto-generate diffstat for any future
patches.
>
>
> > Index: linux-2.6-x86.git/arch/x86/Kconfig
> > ===================================================================
> > --- linux-2.6-x86.git.orig/arch/x86/Kconfig 2008-03-17 11:06:47.000000000 -0700
> > +++ linux-2.6-x86.git/arch/x86/Kconfig 2008-03-17 11:06:51.000000000 -0700
> > @@ -1013,6 +1013,21 @@
> >
> > See <file:Documentation/mtrr.txt> for more information.
> >
> > +config X86_PAT
> > + def_bool y
> > + prompt "x86 PAT support"
> > + depends on MTRR && NONPROMISC_DEVMEM
> > + help
> > + Use PAT attributes to setup page level cache control.
> > + ---help---
> > + PATs are the modern equivalents of MTRRs and are much more
> > + flexible than MTRRs.
> > +
>
> Do 2 help sections actually work? We don't usually do that.
> Just change the second one to a blank line.
>
> > + Say N here if you see bootup problems (boot crash, boot hang,
> > + spontaneous reboots) or a non-working Xorg.
>
> Maybe "a non-working Xorg video driver" ?
> or even omit Xorg and just say video driver?
>
Done with below patch.
Ingo: Please apply.
Thanks,
Venki
Fix double help section in PAT Kconfig. Thanks to Randy Dunlap for catching
this bug.
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
---
arch/x86/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6-x86.git/arch/x86/Kconfig
===================================================================
--- linux-2.6-x86.git.orig/arch/x86/Kconfig 2008-03-21 08:28:47.000000000 -0700
+++ linux-2.6-x86.git/arch/x86/Kconfig 2008-03-24 07:19:35.000000000 -0700
@@ -1019,12 +1019,12 @@ config X86_PAT
depends on MTRR && NONPROMISC_DEVMEM
help
Use PAT attributes to setup page level cache control.
- ---help---
+
PATs are the modern equivalents of MTRRs and are much more
flexible than MTRRs.
Say N here if you see bootup problems (boot crash, boot hang,
- spontaneous reboots) or a non-working Xorg.
+ spontaneous reboots) or a non-working video driver.
If unsure, say Y.
next prev parent reply other threads:[~2008-03-24 21:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-19 0:00 [patch 00/13] x86: PAT support updated - v3 venkatesh.pallipadi
2008-03-19 0:00 ` [patch 01/13] x86: PAT documentation venkatesh.pallipadi
2008-03-19 0:00 ` [patch 02/13] x86: PAT infrastructure patch venkatesh.pallipadi
2008-03-19 20:06 ` Randy Dunlap
2008-03-24 21:22 ` Venki Pallipadi [this message]
2008-03-19 0:00 ` [patch 03/13] x86: PAT Avoid aliasing in /dev/mem read/write venkatesh.pallipadi
2008-03-19 0:00 ` [patch 04/13] x86: PAT make ioremap_change_attr non-static venkatesh.pallipadi
2008-03-19 0:00 ` [patch 05/13] x86: PAT use reserve free memtype in ioremap and iounmap venkatesh.pallipadi
2008-03-19 0:00 ` [patch 06/13] x86: PAT use reserve free memtype in set_memory_uc venkatesh.pallipadi
2008-03-19 0:00 ` [patch 07/13] x86: PAT use reserve free memtype in pci_mmap_page_range venkatesh.pallipadi
2008-03-19 0:00 ` [patch 08/13] x86: PAT phys_mem_access_prot_allowed for dev/mem mmap venkatesh.pallipadi
2008-03-19 0:00 ` [patch 09/13] x86: PAT use reserve free memtype in mmap of /dev/mem venkatesh.pallipadi
2008-03-19 0:00 ` [patch 10/13] x86: PAT export resource_wc in pci sysfs venkatesh.pallipadi
2008-03-19 0:00 ` [patch 11/13] x86: PAT Add set_memory_wc() interface venkatesh.pallipadi
2008-03-19 0:00 ` [patch 12/13] x86: PAT Add ioremap_wc() interface venkatesh.pallipadi
2008-03-19 0:00 ` [patch 13/13] x86: PAT Patch to add PAT related debug prints venkatesh.pallipadi
2008-03-21 13:24 ` [patch 00/13] x86: PAT support updated - v3 Ingo Molnar
2008-03-21 14:55 ` Ingo Molnar
2008-03-21 19:26 ` Venki Pallipadi
2008-03-21 13:29 ` H. Peter Anvin
2008-03-21 19:19 ` Venki Pallipadi
2008-03-21 19:59 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080324212235.GA6783@linux-os.sc.intel.com \
--to=venkatesh.pallipadi@intel.com \
--cc=airlied@skynet.ie \
--cc=ak@muc.de \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=davej@redhat.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=jesse.barnes@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=randy.dunlap@oracle.com \
--cc=rdreier@cisco.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox