Re: [PATCH] x86: PAT bug fix for attribute type check after reserve_memtype

Ingo Molnar
2008-03-25T14:33:51Z

* Venki Pallipadi <venkatesh.pallipadi@intel.com> wrote:

> Bug fixes for reserve_memtype() call in __ioremap and
> pci_mmap_page_range(). If reserve_memtype returns non-zero, then it is
> an error and subsequent free is not required. Requested and returned
> prot value check should be done when reserve_memtype returns success.

thanks, applied.

> + if (retval) {
> + printk("reserve_memtype returned %d\n", retval);

that needs a KERN_INFO, and should be labeled "Warning: ...".

Ingo