From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH FIXED] x86: only enable interrupts when kernel state has been set up
Date: Tue, 25 Mar 2008 11:56:00 +0100 [thread overview]
Message-ID: <20080325105559.GA3729@elte.hu> (raw)
In-Reply-To: <47E83C99.3040800@goop.org>
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> The sysenter path tries to enable interrupts immediately.
> Unfortunately this doesn't work in a paravirt environment, because not
> enough kernel state has been set up at that point (namely, pointing
> %fs to the kernel percpu data segment). To fix this, defer
> ENABLE_INTERRUPTS until after the kernel state has been set up.
>
> Unfortunately this means that we're running with interrupts disabled
> for a while without calling the IRQ tracing code, but that can't be
> called without setting up %fs either.
>
> [ Fix since last posting: make sure saved eflags has interrupts
> enabled. ]
thanks Jeremy - will give it a shot.
Ingo
prev parent reply other threads:[~2008-03-25 10:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-24 23:43 [PATCH FIXED] x86: only enable interrupts when kernel state has been set up Jeremy Fitzhardinge
2008-03-25 10:56 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080325105559.GA3729@elte.hu \
--to=mingo@elte.hu \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox