From: Ingo Molnar <mingo@elte.hu>
To: Venki Pallipadi <venkatesh.pallipadi@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
suresh.b.siddha@intel.com
Subject: Re: [PATCH] x86: PAT bug fix for attribute type check after reserve_memtype
Date: Tue, 25 Mar 2008 15:33:26 +0100 [thread overview]
Message-ID: <20080325143326.GC11323@elte.hu> (raw)
In-Reply-To: <20080324213955.GA10456@linux-os.sc.intel.com>
* Venki Pallipadi <venkatesh.pallipadi@intel.com> wrote:
> Bug fixes for reserve_memtype() call in __ioremap and
> pci_mmap_page_range(). If reserve_memtype returns non-zero, then it is
> an error and subsequent free is not required. Requested and returned
> prot value check should be done when reserve_memtype returns success.
thanks, applied.
> + if (retval) {
> + printk("reserve_memtype returned %d\n", retval);
that needs a KERN_INFO, and should be labeled "Warning: ...".
Ingo
prev parent reply other threads:[~2008-03-25 14:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-24 21:39 [PATCH] x86: PAT bug fix for attribute type check after reserve_memtype Venki Pallipadi
2008-03-25 14:33 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080325143326.GC11323@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox