From: Dean Nelson <dcn@sgi.com>
To: apw@shadowen.org, rdunlap@xenotime.net, jschopp@austin.ibm.com
Cc: jes@sgi.com, linux-kernel@vger.kernel.org, tony.luck@intel.com,
linux-ia64@vger.kernel.org
Subject: Re: [Patch 5/5] run drivers/misc/xp through scripts/checkpatch.pl
Date: Tue, 25 Mar 2008 15:05:17 -0500 [thread overview]
Message-ID: <20080325200517.GA4446@sgi.com> (raw)
In-Reply-To: <20080325192558.959273025@attica.americas.sgi.com>
On Tue, Mar 25, 2008 at 02:25:29PM -0500, dcn@sgi.com wrote:
>
> Addressed issues raised by scripts/checkpatch.pl. Removed unnecessary curly
> braces. Eliminated uses of volatiles and use of kernel_thread() and
> daemonize().
>
> Signed-off-by: Dean Nelson <dcn@sgi.com>
>
Forgot to mention that scripts/checkpatch.pl gave 15 false positives of
the following type against drivers/misc/xp/xp_main.c.
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #48: FILE: misc/xp/xp_main.c:48:
> +EXPORT_SYMBOL_GPL(xp_remote_memcpy);
The fact is that the EXPORT_SYMBOL(xp_remote_memcpy) does immediately follow
the function/variable as follows.
enum xp_retval (*xp_remote_memcpy) (void *dst, const void *src, size_t len);
EXPORT_SYMBOL_GPL(xp_remote_memcpy);
next prev parent reply other threads:[~2008-03-25 20:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-25 19:25 [Patch 0/5] prepare XPC and XPNET to support SGI UV dcn
2008-03-25 19:25 ` [Patch 1/5] add multi-page allocation to the uncached allocator dcn
2008-03-25 19:25 ` [Patch 3/5] prepare XPC and XPNET for future support of SGIs UV architecture dcn
2008-03-25 19:25 ` [Patch 4/5] run drivers/misc/xp through scripts/Lindent dcn
2008-03-25 19:25 ` [Patch 5/5] run drivers/misc/xp through scripts/checkpatch.pl dcn
2008-03-25 20:05 ` Dean Nelson [this message]
2008-03-26 10:03 ` Andy Whitcroft
2008-03-26 16:58 ` Dean Nelson
2008-03-25 20:14 ` [Patch 0/5] prepare XPC and XPNET to support SGI UV Dean Nelson
2008-03-25 22:49 ` Luck, Tony
2008-03-25 23:04 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080325200517.GA4446@sgi.com \
--to=dcn@sgi.com \
--cc=apw@shadowen.org \
--cc=jes@sgi.com \
--cc=jschopp@austin.ibm.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox