From: Brad Sawatzky <brad+debian@swatter.net>
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: [PATCH] usb-serial: fix regression in Visor/Palm OS module for kernels >= 2.6.24
Date: Tue, 25 Mar 2008 22:32:43 -0400 [thread overview]
Message-ID: <20080326023243.GA25564@enigma.swatter.net> (raw)
Fixes a bug/inconsistency revealed by the additional sanity checking in
commit 063a2da8f01806906f7d7b1a1424b9afddebc443
introduced in the original 2.6.24 branch.
The Handspring Visor / PalmOS 4 device structure defines .num_bulk_out=2
but the usb-serial probe returns num_bulk_out=3, triggering the check in
the above commit and forcing a bail out when the device (a Garmin iQue in
my case) attempts to connect. The patch bumps the expected number of
endpoints to 3.
I suppose it's possible that the kernel is identifying 3 bulk endpoints
when there should only be 2 and there is some issue with the lower level
endpoint probe?
FWIW, this patch will probably solve the following kernel bug report for
Treo users (identical symptoms, different model PalmOS units):
<http://bugzilla.kernel.org/show_bug.cgi?id=10118>
Signed-off-by: Brad Sawatzky <brad+kernel@swatter.net>
---
--- drivers/usb/serial/visor.c.orig 2008-03-25 21:32:40.000000000 -0400
+++ drivers/usb/serial/visor.c 2008-03-25 21:29:57.000000000 -0400
@@ -191,7 +191,7 @@ static struct usb_serial_driver handspri
.id_table = id_table,
.num_interrupt_in = NUM_DONT_CARE,
.num_bulk_in = 2,
- .num_bulk_out = 2,
+ .num_bulk_out = 3,
.num_ports = 2,
.open = visor_open,
.close = visor_close,
next reply other threads:[~2008-03-26 3:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 2:32 Brad Sawatzky [this message]
2008-03-26 7:17 ` [PATCH] usb-serial: fix regression in Visor/Palm OS module for kernels >= 2.6.24 Oliver Neukum
2008-03-27 0:15 ` Brad Sawatzky
2008-03-27 2:55 ` Alan Stern
2008-03-27 5:07 ` Brad Sawatzky
2008-03-27 6:41 ` Charles Banas
2008-03-27 8:56 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080326023243.GA25564@enigma.swatter.net \
--to=brad+debian@swatter.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox