public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	bugme-daemon@bugzilla.kernel.org, linux-kernel@vger.kernel.org,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	venkatesh.pallipadi@intel.com, arjan@linux.intel.com,
	bug-track@fisher-privat.net
Subject: Re: [Bug 10328] New: [regression] performance drop for glx
Date: Wed, 26 Mar 2008 06:29:11 +0100	[thread overview]
Message-ID: <20080326052911.GA8173@elte.hu> (raw)
In-Reply-To: <20080326003912.GB3313@linux-os.sc.intel.com>


* Suresh Siddha <suresh.b.siddha@intel.com> wrote:

> fb drivers are using ioremap()/ioremap_nocache(), followed by mtrr_add 
> with WC attribute. Recent changes in page attribute code made both 
> ioremap()/ioremap_nocache() mappings as UC (instead of previous UC-). 
> This breaks the graphics performance, as the effective memory type is 
> UC instead of expected WC.
> 
> The correct way to fix this is to add ioremap_wc() (which uses UC- in 
> the absence of PAT kernel support and WC with PAT) and change all the 
> fb drivers to use this new ioremap_wc() API.
> 
> We can take this correct and longer route for post 2.6.25. For now, 
> revert back to the UC- behavior for ioremap/ioremap_nocache.

thanks Suresh, applied.

	Ingo

  parent reply	other threads:[~2008-03-26  5:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-10328-27@http.bugzilla.kernel.org/>
2008-03-25 22:28 ` [Bug 10328] New: [regression] performance drop for glx Andrew Morton
2008-03-26  0:39   ` Suresh Siddha
2008-03-26  4:42     ` Arjan van de Ven
2008-04-25  5:35       ` Alexey Fisher
2008-04-26  0:07         ` Suresh Siddha
2008-04-26 11:43           ` Alexey Fisher
2008-04-28 16:34           ` Ingo Molnar
2008-03-26  5:29     ` Ingo Molnar [this message]
2008-03-26 17:55       ` Suresh Siddha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080326052911.GA8173@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@linux.intel.com \
    --cc=bug-track@fisher-privat.net \
    --cc=bugme-daemon@bugzilla.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox