From: Jarod Wilson <jwilson@redhat.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firewire: fw-ohci: plug dma memory leak in AR handler
Date: Wed, 26 Mar 2008 09:09:49 -0400 [thread overview]
Message-ID: <200803260909.49850.jwilson@redhat.com> (raw)
In-Reply-To: <47E9F6BB.4010601@s5r6.in-berlin.de>
On Wednesday 26 March 2008 03:09:47 am Stefan Richter wrote:
> Jarod Wilson wrote:
> > @@ -605,7 +606,7 @@ static void ar_context_tasklet(unsigned long data)
> > buffer = handle_ar_packet(ctx, buffer);
> >
> > dma_free_coherent(ohci->card.device, PAGE_SIZE,
> > - buffer, buffer_bus);
> > + start, start_bus);
> > ar_context_add_page(ctx);
>
> On the other hand, why do we free a page + allocate a page?
> Why don't we re-initialize and re-add the old page?
Oh good, I'm not crazy (outside of having firewire on the brain way too much
right now). I had that same thought tossing and turning in bed late last
night. :)
--
Jarod Wilson
jwilson@redhat.com
next prev parent reply other threads:[~2008-03-26 13:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-25 20:47 [PATCH] firewire: fw-ohci: plug dma memory leak in AR handler Jarod Wilson
2008-03-25 22:29 ` Stefan Richter
2008-03-26 7:09 ` Stefan Richter
2008-03-26 13:09 ` Jarod Wilson [this message]
2008-03-26 23:50 ` Stefan Richter
2008-03-27 7:56 ` Stefan Richter
2008-03-26 21:37 ` Jarod Wilson
2008-03-27 0:12 ` Stefan Richter
2008-03-27 2:17 ` Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803260909.49850.jwilson@redhat.com \
--to=jwilson@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox