public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Ingo Molnar <mingo@elte.hu>, Corentin CHARY <corentincj@iksaif.net>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@lists.linux-foundation.org
Subject: ISA -> ISA_ (Re: [GIT PATCH] ACPI patches for 2.6.25-rc6)
Date: Wed, 26 Mar 2008 11:32:20 -0400	[thread overview]
Message-ID: <200803261132.21448.lenb@kernel.org> (raw)
In-Reply-To: <20080326081653.GA8247@elte.hu>


> btw., saw this ACPI-ish commit in rc7:
> 
> | commit b97d4803400a4442b0e4ae14d0bd8e83994b9004
> | Author: Bjorn Helgaas <bjorn.helgaas@hp.com>
> | Date:   Tue Mar 25 11:21:11 2008 -0600
> |
> |    ACPI: fix Medion _PRT quirk (use "ISA_", not "ISA")
> 
> a grep shows that we've got one other case of an "ISA" string in the 
> ACPI code - is the patch below needed too?
> 
> 	Ingo
> 
> -------------------->
> Subject: acpi: fix asus isa
> From: Ingo Molnar <mingo@elte.hu>
> Date: Wed Mar 26 09:05:07 CET 2008
> 
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
>  drivers/acpi/asus_acpi.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-x86.q/drivers/acpi/asus_acpi.c
> ===================================================================
> --- linux-x86.q.orig/drivers/acpi/asus_acpi.c
> +++ linux-x86.q/drivers/acpi/asus_acpi.c
> @@ -149,7 +149,7 @@ struct asus_hotk {
>  };
>  
>  /* Here we go */
> -#define A1x_PREFIX "\\_SB.PCI0.ISA.EC0."
> +#define A1x_PREFIX "\\_SB.PCI0.ISA_.EC0."

>From an AML point of view, ISA is just as legal as "ISA_"
The NameString paramter to Device() can be 1 to 4 characters.

So if this is correct or not depends on what the BIOS programmer
for the Asus A1x choose to write.  Perhaps Corentin 'Iksaif' CHARY
can confirm if the driver is working properly on that system.

-Len

>  #define L3C_PREFIX "\\_SB.PCI0.PX40.ECD0."
>  #define M1A_PREFIX "\\_SB.PCI0.PX40.EC0."
>  #define P30_PREFIX "\\_SB.PCI0.LPCB.EC0."
> 



  reply	other threads:[~2008-03-26 15:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-18  9:10 [GIT PATCH] ACPI patches for 2.6.25-rc6 Len Brown
2008-03-26  8:16 ` Ingo Molnar
2008-03-26 15:32   ` Len Brown [this message]
2008-03-26 15:45     ` ISA -> ISA_ (Re: [GIT PATCH] ACPI patches for 2.6.25-rc6) Corentin CHARY
2008-03-26 16:33       ` Henrique de Moraes Holschuh
2008-03-26 15:56     ` Bjorn Helgaas
2008-03-26 17:24       ` Alexey Starikovskiy
2008-03-26 18:47         ` Bjorn Helgaas
2008-03-26 19:21           ` Alexey Starikovskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803261132.21448.lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=bjorn.helgaas@hp.com \
    --cc=corentincj@iksaif.net \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox