public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andres Salomon <dilinger@queued.net>
To: Jordan Crouse <jordan.crouse@amd.com>
Cc: Stefan Pfetzing <dreamind@dreamind.de>,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	mingo@redhat.com, hpa@zytor.com,
	Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH] x86: GEODE: add missing module.h include
Date: Wed, 26 Mar 2008 14:13:01 -0400	[thread overview]
Message-ID: <20080326141301.2b675414@ephemeral> (raw)
In-Reply-To: <20080326175622.GB32151@cosmic.amd.com>

On Wed, 26 Mar 2008 11:56:22 -0600
Jordan Crouse <jordan.crouse@amd.com> wrote:

> On 26/03/08 14:31 +0100, Stefan Pfetzing wrote:
> > Hello Jordan,
> >
> > I just tried to build your geodwdt driver for the geode watchdog. Therefore 
> > I pulled your repository from http://git.infradead.org/geode.git (or more, 
> > the git url).
> >
> > I tried to build the geodewdt driver as a module - which didn't work, and 
> > it failed with the same problem as earlier mentioned on lkmk [1]. I also 
> > checked the fix [2], but that seems to be already in your (or linus) tree - 
> > and so I'm unsure what the problem is.
> >
> > [1] http://kerneltrap.org/mailarchive/linux-kernel/2008/2/17/884074
> > [2] http://kerneltrap.org/mailarchive/linux-kernel/2008/2/17/884174
> >
> > Building directly into the kernel seems to work.
> >
> > Maybe you have some idea?
> 
> Hmm - that is strange.  Exporting the symbols should work.  I recommend
> starting over with a clean tree.
> 
> CCing Andres - any thoughts?
> 
> Jordan
> 


Er, yeah.  The patch below should fix it.  This should probably go into
2.6.25.





Oops, EXPORT_SYMBOL_GPL wasn't being declared due to this header
being missing.

Signed-off-by: Andres Salomon <dilinger@debian.org>
---
 arch/x86/kernel/mfgpt_32.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/mfgpt_32.c b/arch/x86/kernel/mfgpt_32.c
index 3f0f603..2c0e6b5 100644
--- a/arch/x86/kernel/mfgpt_32.c
+++ b/arch/x86/kernel/mfgpt_32.c
@@ -30,6 +30,7 @@
 
 #include <linux/kernel.h>
 #include <linux/interrupt.h>
+#include <linux/module.h>
 #include <asm/geode.h>
 
 static struct mfgpt_timer_t {
-- 
1.5.3.7


           reply	other threads:[~2008-03-26 18:12 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20080326175622.GB32151@cosmic.amd.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080326141301.2b675414@ephemeral \
    --to=dilinger@queued.net \
    --cc=akpm@linux-foundation.org \
    --cc=dreamind@dreamind.de \
    --cc=hpa@zytor.com \
    --cc=jordan.crouse@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox