From: Jesse Barnes <jesse.barnes@intel.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Dave Airlie <airlied@linux.ie>
Subject: [PATCH] don't suspend/resume 8xx chips
Date: Wed, 26 Mar 2008 16:28:12 -0700 [thread overview]
Message-ID: <200803261628.12336.jesse.barnes@intel.com> (raw)
Recent testing has turned up some bugs in the new Intel suspend/resume code
for old, 8xx chipsets. So for 2.6.25 it probably makes sense to apply this
patch, which should prevent the new code from getting called on those
chipsets. We should have this fixed soon, but not in time for 2.6.25
unfortunately. Note that this patch (along with the suspend/resume code in
general) could use more testing.
Signed-off-by: Jesse Barnes <jesse.barnes@intel.com>
diff --git a/drivers/char/drm/i915_dma.c b/drivers/char/drm/i915_dma.c
index e9d6663..6964a28 100644
--- a/drivers/char/drm/i915_dma.c
+++ b/drivers/char/drm/i915_dma.c
@@ -762,6 +762,11 @@ int i915_driver_load(struct drm_device *dev, unsigned
long
unsigned long base, size;
int ret = 0, mmio_bar = IS_I9XX(dev) ? 0 : 1;
+ if (!IS_I9XX(dev)) {
+ dev->driver->suspend = NULL;
+ dev->driver->resume = NULL;
+ }
+
/* i915 has 4 more counters */
dev->counters += 4;
dev->types[6] = _DRM_STAT_IRQ;
next reply other threads:[~2008-03-26 23:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 23:28 Jesse Barnes [this message]
2008-03-27 8:38 ` [PATCH] don't suspend/resume 8xx chips Soren Hansen
2008-05-05 22:07 ` Jesse Barnes
2008-03-28 14:40 ` Pavel Machek
2008-03-28 20:13 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803261628.12336.jesse.barnes@intel.com \
--to=jesse.barnes@intel.com \
--cc=airlied@linux.ie \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox