From: Ingo Molnar <mingo@elte.hu>
To: Alan Mayer <ajm@sgi.com>
Cc: torvalds@linux-foundation.org,
linux-kernel list <linux-kernel@vger.kernel.org>,
Robin Holt <holt@sgi.com>, Jack Steiner <steiner@sgi.com>,
Russ Anderson <rja@sgi.com>
Subject: Re: [PATCH] x86_64: resize NR_IRQS for large machines (re-submit)
Date: Wed, 26 Mar 2008 22:23:12 +0100 [thread overview]
Message-ID: <20080326212312.GA27594@elte.hu> (raw)
In-Reply-To: <Pine.SGI.3.96.1080326161017.7873204a-100000@fergus.americas.sgi.com>
* Alan Mayer <ajm@sgi.com> wrote:
> On machines with very large numbers of cpus, tables that are
> dimensioned by NR_IRQS get very large, especially the irq_desc table.
> They are also very sparsely used. When the cpu count is >
> MAX_IO_APICS, use MAX_IO_APICS to set NR_IRQS, otherwise use NR_CPUS.
thanks Alan, applied this in place of the other patch.
this bit is still ugly:
> -#define NR_IRQS (NR_VECTORS + (32 *NR_CPUS))
> +#if NR_CPUS < MAX_IO_APICS
> +#define NR_IRQS (NR_VECTORS + (32 * NR_CPUS))
> +#else
> +#define NR_IRQS (NR_VECTORS + (32 * MAX_IO_APICS))
> +#endif
> #define NR_IRQ_VECTORS NR_IRQS
but it doesnt really depart from the current status quo of huge
[NR_IRQS] arrays either. Patches that make NR_IRQS a variable are
welcome :)
Ingo
next prev parent reply other threads:[~2008-03-26 21:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 21:11 [PATCH] x86_64: resize NR_IRQS for large machines (re-submit) Alan Mayer
2008-03-26 21:23 ` Ingo Molnar [this message]
2008-03-26 21:40 ` Alan Mayer
2008-03-26 22:24 ` Ingo Molnar
2008-03-27 16:16 ` Alan Mayer
2008-03-27 16:33 ` Ingo Molnar
2008-03-27 16:53 ` Alan Mayer
2008-03-28 9:32 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080326212312.GA27594@elte.hu \
--to=mingo@elte.hu \
--cc=ajm@sgi.com \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rja@sgi.com \
--cc=steiner@sgi.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox