public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Pavel Machek <pavel@ucw.cz>
Cc: Andi Kleen <andi@firstfloor.org>,
	kernel list <linux-kernel@vger.kernel.org>,
	Greg KH <greg@kroah.com>, "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: iommu breaks usb after resume
Date: Thu, 27 Mar 2008 00:00:17 +0100	[thread overview]
Message-ID: <20080326230017.GA21017@elte.hu> (raw)
In-Reply-To: <20080326225407.GA9378@elf.ucw.cz>


* Pavel Machek <pavel@ucw.cz> wrote:

> @@ -733,8 +735,8 @@ static struct pci_driver agp_amd64_pci_d
>  	.probe		= agp_amd64_probe,
>  	.remove		= agp_amd64_remove,
>  #ifdef CONFIG_PM
> -	.suspend	= agp_amd64_suspend,
> -	.resume		= agp_amd64_resume,
> +	.suspend_late	= agp_amd64_suspend,
> +	.resume_early	= agp_amd64_resume,
>  #endif

ah, makes sense. I've queued up your fix in x86.git (sans the debug 
printks), please send your signoff once you can verify that it solves 
the hibernation hang on your box and we'll push it into 2.6.25.

	Ingo

  reply	other threads:[~2008-03-26 23:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-20 11:14 iommu breaks usb after resume Pavel Machek
2008-03-21 13:27 ` Ingo Molnar
2008-03-21 13:54 ` Andi Kleen
2008-03-26 10:21   ` Pavel Machek
2008-03-26 13:00     ` Andi Kleen
2008-03-26 22:54       ` Pavel Machek
2008-03-26 23:00         ` Ingo Molnar [this message]
2008-03-26 23:05           ` Pavel Machek
2008-03-27  5:53             ` Andi Kleen
2008-03-27  8:41               ` Pavel Machek
2008-03-27  8:42           ` Pavel Machek
2008-03-27  8:47             ` (eats disks) " Pavel Machek
2008-03-27  9:59             ` Pavel Machek
2008-03-27 11:49               ` Andi Kleen
2008-03-27 13:29                 ` Pavel Machek
2008-03-27 13:34                   ` Andi Kleen
2008-03-27 20:30         ` Rafael J. Wysocki
2008-03-27 23:40           ` Pavel Machek
2008-03-27 23:52             ` Rafael J. Wysocki
2008-03-28 13:50               ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080326230017.GA21017@elte.hu \
    --to=mingo@elte.hu \
    --cc=andi@firstfloor.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox