public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: ying.huang@intel.com, hpa@zytor.com, andi@firstfloor.org,
	mingo@redhat.com, tglx@linutronix.de,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 0/4] x86_64 boot: Add linked listof struct setup_data to boot protocol
Date: Thu, 27 Mar 2008 04:02:16 -0500	[thread overview]
Message-ID: <20080327040216.99dcde7b.pj@sgi.com> (raw)
In-Reply-To: <20080327083221.GD15626@elte.hu>

Ingo asked:
> what happens with the SGI machine

Unless I misunderstand your post, Ingo, you don't need an SGI machine
for this one, ... just a compiler ;).

In the file arch/x86/boot/main.c, see the line:

    BUILD_BUG_ON(sizeof boot_params != 4096);

This BUILD_BUG is serving as a reminder that the PC's "zero page", such
as is encoded in the struct boot_params (include/asm-x86/bootparam.h)
has to be exactly 4096 bytes by traditional PC architecture.  One of
the entries in that struct is:

    struct e820entry e820_map[E820MAX];             /* 0x2d0 */

H. Peter Anvin, Andi Kleen and Huang had further discussion in an
earlier email thread as to how to best extend this limit.  I trust
that Huang's patch represents their concensus of that discussion.

By the way, Peter, do you have any idea what that E820NR define is
doing in include/asm-x86/e820.h ... it looks like useless redundancy
to me?

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.940.382.4214

  reply	other threads:[~2008-03-27  9:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-27  7:09 [PATCH -mm 0/4] x86_64 boot: Add linked listof struct setup_data to boot protocol Huang, Ying
2008-03-27  8:32 ` Ingo Molnar
2008-03-27  9:02   ` Paul Jackson [this message]
2008-03-27  9:09     ` Ingo Molnar
2008-03-27  9:21       ` Paul Jackson
2008-03-27  9:46         ` Ingo Molnar
2008-03-27  9:25   ` Huang, Ying
2008-03-27  9:47     ` Ingo Molnar
2008-03-27 16:36       ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080327040216.99dcde7b.pj@sgi.com \
    --to=pj@sgi.com \
    --cc=andi@firstfloor.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox